public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [patch] OptionRomPkg: Fix GCC build failure
@ 2016-09-22  2:51 Dandan Bi
  2016-10-09  3:14 ` Ni, Ruiyu
  0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2016-09-22  2:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ruiyu Ni

Remove the variable which is set but not used to pass GCC build.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
index dd18a95..73d54f0 100644
--- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
+++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
@@ -665,11 +665,10 @@ FillPkt2Queue (
   UINT16 * pLength;
   UINT16 * pLengthBar;
   UINT8* pData;
   UINT32 offset;
   RX_TX_PACKET * pRxPacket;
-  UINTN LengthInBytes;
   EFI_STATUS Status;
   
   for ( offset = 0; offset < BufLength; ){
     pLength = (UINT16*) (pNicDevice->pBulkInBuff + offset);
     pLengthBar = (UINT16*) (pNicDevice->pBulkInBuff + offset +2);
@@ -682,11 +681,10 @@ FillPkt2Queue (
       DEBUG (( EFI_D_ERROR , "Pkt length error. BufLength = %d\n", BufLength));
       return;
     }
       
     pRxPacket = pNicDevice->pRxFree;
-    LengthInBytes = sizeof ( *pRxPacket ) - sizeof ( pRxPacket->pNext );
     if ( NULL == pRxPacket ) {
       Status = gBS->AllocatePool ( EfiRuntimeServicesData,
                                    sizeof( RX_TX_PACKET ),
                                    (VOID **) &pRxPacket );
       if ( !EFI_ERROR ( Status )) {
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] OptionRomPkg: Fix GCC build failure
  2016-09-22  2:51 [patch] OptionRomPkg: Fix GCC build failure Dandan Bi
@ 2016-10-09  3:14 ` Ni, Ruiyu
  0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2016-10-09  3:14 UTC (permalink / raw)
  To: Bi, Dandan, edk2-devel@lists.01.org


Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Pushed as ea79dc2b77d8438f840e85b44a43760337637a6a.
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, September 22, 2016 10:51 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] OptionRomPkg: Fix GCC build failure
> 
> Remove the variable which is set but not used to pass GCC build.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> index dd18a95..73d54f0 100644
> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
> @@ -665,11 +665,10 @@ FillPkt2Queue (
>    UINT16 * pLength;
>    UINT16 * pLengthBar;
>    UINT8* pData;
>    UINT32 offset;
>    RX_TX_PACKET * pRxPacket;
> -  UINTN LengthInBytes;
>    EFI_STATUS Status;
> 
>    for ( offset = 0; offset < BufLength; ){
>      pLength = (UINT16*) (pNicDevice->pBulkInBuff + offset);
>      pLengthBar = (UINT16*) (pNicDevice->pBulkInBuff + offset +2); @@ -
> 682,11 +681,10 @@ FillPkt2Queue (
>        DEBUG (( EFI_D_ERROR , "Pkt length error. BufLength = %d\n",
> BufLength));
>        return;
>      }
> 
>      pRxPacket = pNicDevice->pRxFree;
> -    LengthInBytes = sizeof ( *pRxPacket ) - sizeof ( pRxPacket->pNext );
>      if ( NULL == pRxPacket ) {
>        Status = gBS->AllocatePool ( EfiRuntimeServicesData,
>                                     sizeof( RX_TX_PACKET ),
>                                     (VOID **) &pRxPacket );
>        if ( !EFI_ERROR ( Status )) {
> --
> 1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-09  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-22  2:51 [patch] OptionRomPkg: Fix GCC build failure Dandan Bi
2016-10-09  3:14 ` Ni, Ruiyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox