public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function
Date: Tue, 11 Oct 2016 02:15:41 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E17C4C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1476150295-7112-1-git-send-email-liming.gao@intel.com>


Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, October 11, 2016 9:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the
> function
> 
> The function with the variable parameters should have EFIAPI.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  DuetPkg/DxeIpl/Debug.c | 1 +
>  DuetPkg/DxeIpl/Debug.h | 1 +
>  DuetPkg/EfiLdr/Debug.c | 1 +
>  DuetPkg/EfiLdr/Debug.h | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/DuetPkg/DxeIpl/Debug.c b/DuetPkg/DxeIpl/Debug.c index
> 1cb7e39..800f008 100644
> --- a/DuetPkg/DxeIpl/Debug.c
> +++ b/DuetPkg/DxeIpl/Debug.c
> @@ -52,6 +52,7 @@ ClearScreen (
>  }
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/DxeIpl/Debug.h b/DuetPkg/DxeIpl/Debug.h index
> 7fcad26..81bb826 100644
> --- a/DuetPkg/DxeIpl/Debug.h
> +++ b/DuetPkg/DxeIpl/Debug.h
> @@ -27,6 +27,7 @@ PrintHeader (
>    );
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/EfiLdr/Debug.c b/DuetPkg/EfiLdr/Debug.c index
> 84b2772..0727292 100644
> --- a/DuetPkg/EfiLdr/Debug.c
> +++ b/DuetPkg/EfiLdr/Debug.c
> @@ -49,6 +49,7 @@ ClearScreen (
>  }
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/EfiLdr/Debug.h b/DuetPkg/EfiLdr/Debug.h index
> f6aa7a2..4252f31 100644
> --- a/DuetPkg/EfiLdr/Debug.h
> +++ b/DuetPkg/EfiLdr/Debug.h
> @@ -27,6 +27,7 @@ PrintHeader (
>    );
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> --
> 2.8.0.windows.1



      reply	other threads:[~2016-10-11  2:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11  1:44 [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function Liming Gao
2016-10-11  2:15 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D58E17C4C@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox