public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function
@ 2016-10-11  1:44 Liming Gao
  2016-10-11  2:15 ` Ni, Ruiyu
  0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2016-10-11  1:44 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ruiyu Ni

The function with the variable parameters should have EFIAPI.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 DuetPkg/DxeIpl/Debug.c | 1 +
 DuetPkg/DxeIpl/Debug.h | 1 +
 DuetPkg/EfiLdr/Debug.c | 1 +
 DuetPkg/EfiLdr/Debug.h | 1 +
 4 files changed, 4 insertions(+)

diff --git a/DuetPkg/DxeIpl/Debug.c b/DuetPkg/DxeIpl/Debug.c
index 1cb7e39..800f008 100644
--- a/DuetPkg/DxeIpl/Debug.c
+++ b/DuetPkg/DxeIpl/Debug.c
@@ -52,6 +52,7 @@ ClearScreen (
 }
 
 VOID
+EFIAPI
 PrintString (
   IN CONST CHAR8  *FormatString,
   ...
diff --git a/DuetPkg/DxeIpl/Debug.h b/DuetPkg/DxeIpl/Debug.h
index 7fcad26..81bb826 100644
--- a/DuetPkg/DxeIpl/Debug.h
+++ b/DuetPkg/DxeIpl/Debug.h
@@ -27,6 +27,7 @@ PrintHeader (
   );
 
 VOID
+EFIAPI
 PrintString (
   IN CONST CHAR8  *FormatString,
   ...
diff --git a/DuetPkg/EfiLdr/Debug.c b/DuetPkg/EfiLdr/Debug.c
index 84b2772..0727292 100644
--- a/DuetPkg/EfiLdr/Debug.c
+++ b/DuetPkg/EfiLdr/Debug.c
@@ -49,6 +49,7 @@ ClearScreen (
 }
 
 VOID
+EFIAPI
 PrintString (
   IN CONST CHAR8  *FormatString,
   ...
diff --git a/DuetPkg/EfiLdr/Debug.h b/DuetPkg/EfiLdr/Debug.h
index f6aa7a2..4252f31 100644
--- a/DuetPkg/EfiLdr/Debug.h
+++ b/DuetPkg/EfiLdr/Debug.h
@@ -27,6 +27,7 @@ PrintHeader (
   );
 
 VOID
+EFIAPI
 PrintString (
   IN CONST CHAR8  *FormatString,
   ...
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function
  2016-10-11  1:44 [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function Liming Gao
@ 2016-10-11  2:15 ` Ni, Ruiyu
  0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2016-10-11  2:15 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org


Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, October 11, 2016 9:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the
> function
> 
> The function with the variable parameters should have EFIAPI.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  DuetPkg/DxeIpl/Debug.c | 1 +
>  DuetPkg/DxeIpl/Debug.h | 1 +
>  DuetPkg/EfiLdr/Debug.c | 1 +
>  DuetPkg/EfiLdr/Debug.h | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/DuetPkg/DxeIpl/Debug.c b/DuetPkg/DxeIpl/Debug.c index
> 1cb7e39..800f008 100644
> --- a/DuetPkg/DxeIpl/Debug.c
> +++ b/DuetPkg/DxeIpl/Debug.c
> @@ -52,6 +52,7 @@ ClearScreen (
>  }
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/DxeIpl/Debug.h b/DuetPkg/DxeIpl/Debug.h index
> 7fcad26..81bb826 100644
> --- a/DuetPkg/DxeIpl/Debug.h
> +++ b/DuetPkg/DxeIpl/Debug.h
> @@ -27,6 +27,7 @@ PrintHeader (
>    );
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/EfiLdr/Debug.c b/DuetPkg/EfiLdr/Debug.c index
> 84b2772..0727292 100644
> --- a/DuetPkg/EfiLdr/Debug.c
> +++ b/DuetPkg/EfiLdr/Debug.c
> @@ -49,6 +49,7 @@ ClearScreen (
>  }
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> diff --git a/DuetPkg/EfiLdr/Debug.h b/DuetPkg/EfiLdr/Debug.h index
> f6aa7a2..4252f31 100644
> --- a/DuetPkg/EfiLdr/Debug.h
> +++ b/DuetPkg/EfiLdr/Debug.h
> @@ -27,6 +27,7 @@ PrintHeader (
>    );
> 
>  VOID
> +EFIAPI
>  PrintString (
>    IN CONST CHAR8  *FormatString,
>    ...
> --
> 2.8.0.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-11  2:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11  1:44 [Patch] DuetPkg DxeIpl and EfiLdr: Add the missing EFIAPI for the function Liming Gao
2016-10-11  2:15 ` Ni, Ruiyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox