From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.
Date: Fri, 14 Oct 2016 01:36:13 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E343F3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1476275967-10888-1-git-send-email-eric.dong@intel.com>
Please remove the ending back-slash in following lines. They are not needed.
+ while (MaxSize >= sizeof (EFI_DEVICE_PATH_PROTOCOL) && \
+ (MaxSize - sizeof (EFI_DEVICE_PATH_PROTOCOL) >= Size) && \
+ !IsDevicePathEnd (DevicePath)) {
With the above changes, Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Eric Dong
>Sent: Wednesday, October 12, 2016 8:39 PM
>To: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.
>
>In IsDevicePathValid API, code should validate the device path
>buffer not exceed the input MaxSize before reference the path
>info. This patched series add this check.
>
>Eric Dong (2):
> MdePkg UefiDevicePathLib: Validate buffer length before use buffer.
> MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.
>
> .../UefiDevicePathLib/DevicePathUtilities.c | 25 ++++++++++++++++------
> .../UefiDevicePathLib.c | 24 +++++++++++++++------
> 2 files changed, 35 insertions(+), 14 deletions(-)
>
>--
>2.6.4.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-10-14 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:39 [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use Eric Dong
2016-10-12 12:39 ` [Patch 1/2] MdePkg UefiDevicePathLib: Validate buffer length before use buffer Eric Dong
2016-10-12 12:39 ` [Patch 2/2] MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use Eric Dong
2016-10-12 14:14 ` [Patch 0/2] MdePkg DevicePathLib: Check buffer length " Laszlo Ersek
2016-10-14 1:36 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D58E343F3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox