From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28D281A1E60 for ; Wed, 19 Oct 2016 00:51:54 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP; 19 Oct 2016 00:51:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,513,1473145200"; d="scan'208";a="21188253" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2016 00:51:53 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 19 Oct 2016 00:51:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.209]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Wed, 19 Oct 2016 15:51:49 +0800 From: "Ni, Ruiyu" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH 30/33] ShellPkg: Fix typos in comments and variables Thread-Index: AQHSKdcBzsgWVsA7+0G+DUHQxfdJn6CvZ5jQ Date: Wed, 19 Oct 2016 07:51:49 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E3885D@SHSMSX104.ccr.corp.intel.com> References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-31-glin@suse.com> In-Reply-To: <20161019070138.16424-31-glin@suse.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 30/33] ShellPkg: Fix typos in comments and variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 07:51:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH 30/33] ShellPkg: Fix typos in comments and variables >=20 > - funciton -> function > - paramter -> parameter > - supresses -> suppresses > - Seperator -> Separator > - permenant -> permanent >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin > --- > ShellPkg/Include/Library/ShellCEntryLib.h = | 2 +- > ShellPkg/Include/Library/ShellCommandLib.h = | 2 +- > ShellPkg/Include/Protocol/EfiShellEnvironment2.h = | 2 +- > ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c = | 2 +- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c = | 10 +++++- > ---- >=20 > ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib > .c | 2 +- > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c = | 8 > ++++---- > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c = | 8 > ++++---- > 8 files changed, 18 insertions(+), 18 deletions(-) >=20 > diff --git a/ShellPkg/Include/Library/ShellCEntryLib.h > b/ShellPkg/Include/Library/ShellCEntryLib.h > index dfbb16f..e4983f8 100644 > --- a/ShellPkg/Include/Library/ShellCEntryLib.h > +++ b/ShellPkg/Include/Library/ShellCEntryLib.h > @@ -1,5 +1,5 @@ > /** @file > - Provides application point extension for "C" style main funciton. > + Provides application point extension for "C" style main function. >=20 > Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
> This program and the accompanying materials diff --git > a/ShellPkg/Include/Library/ShellCommandLib.h > b/ShellPkg/Include/Library/ShellCommandLib.h > index 3ee8200..5ff1e4f 100644 > --- a/ShellPkg/Include/Library/ShellCommandLib.h > +++ b/ShellPkg/Include/Library/ShellCommandLib.h > @@ -2,7 +2,7 @@ > Provides interface to shell internal functions for shell commands. >=20 > This library is for use ONLY by shell commands linked into the shell > application. > - This library will not funciton if it is used for UEFI Shell 2.0 Applic= ations. > + This library will not function if it is used for UEFI Shell 2.0 Applic= ations. >=20 > Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
diff = -- > git a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > index 1aa1b7e..ac6c6a0 100644 > --- a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > +++ b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > @@ -124,7 +124,7 @@ GUID for the shell environment2 extension (main > GUID above). > @param[in] ParentImageHandle Handle of the image executing this > operation. > @param[in] CommandLine The string command line to execute. > @param[in] DebugOutput TRUE indicates that errors should be pri= nted > directly. > - FALSE supresses error messages. > + FALSE suppresses error messages. >=20 > @retval EFI_SUCCESS The command line executed and completed. > @retval EFI_ABORTED The operation aborted. > diff --git a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > index 525c1f1..faed230 100644 > --- a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > +++ b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > @@ -1,5 +1,5 @@ > /** @file > - Provides application point extension for "C" style main funciton > + Provides application point extension for "C" style main function >=20 > Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.
> This program and the accompanying materials diff --git > a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > index 00a4c10..e07304c 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > @@ -130,7 +130,7 @@ IsDriverProt ( >=20 > @param[in] TheHandle The handles to show info on. > @param[in] Language Language string per UEFI specification. > - @param[in] Seperator Separator string between information block= s. > + @param[in] Separator Separator string between information block= s. > @param[in] Verbose TRUE for extra info, FALSE otherwise. > @param[in] ExtraInfo TRUE for extra info, FALSE otherwise. >=20 > @@ -141,7 +141,7 @@ CHAR16* > GetProtocolInfoString( > IN CONST EFI_HANDLE TheHandle, > IN CONST CHAR8 *Language, > - IN CONST CHAR16 *Seperator, > + IN CONST CHAR16 *Separator, > IN CONST BOOLEAN Verbose, > IN CONST BOOLEAN ExtraInfo > ) > @@ -169,7 +169,7 @@ GetProtocolInfoString( > if (Temp !=3D NULL) { > ASSERT((RetVal =3D=3D NULL && Size =3D=3D 0) || (RetVal !=3D NUL= L)); > if (Size !=3D 0) { > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > + StrnCatGrow(&RetVal, &Size, Separator, 0); > } > StrnCatGrow(&RetVal, &Size, L"%H", 0); > StrnCatGrow(&RetVal, &Size, Temp, 0); @@ -185,7 +185,7 @@ > GetProtocolInfoString( > StrnCatGrow(&RetVal, &Size, Temp, 0); > StrnCatGrow(&RetVal, &Size, L")\r\n", 0); > } else { > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > + StrnCatGrow(&RetVal, &Size, Separator, 0); > StrnCatGrow(&RetVal, &Size, Temp, 0); > } > FreePool(Temp); > @@ -201,7 +201,7 @@ GetProtocolInfoString( > } >=20 > ASSERT((RetVal =3D=3D NULL && Size =3D=3D 0) || (RetVal !=3D NULL)); > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > + StrnCatGrow(&RetVal, &Size, Separator, 0); > return (RetVal); > } >=20 > diff --git > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > index 1491ee9..7948e53 100644 > --- > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > +++ > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Command > +++ sLib.c > @@ -99,7 +99,7 @@ ShellLevel2CommandsLibConstructor ( > ShellCommandRegisterCommandName(L"vol", ShellCommandRunVol , > ShellCommandGetManFileNameLevel2, 2, L"", TRUE, gShellLevel2HiiHandle, > STRING_TOKEN(STR_GET_HELP_VOL) ); >=20 > // > - // support for permenant (built in) aliases > + // support for permanent (built in) aliases > // > ShellCommandRegisterAlias(L"rm", L"del"); > ShellCommandRegisterAlias(L"ls", L"dir"); diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > index 38625fe..70d9d9a 100644 > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > @@ -1492,7 +1492,7 @@ ShellCommandRunPing ( > } >=20 > // > - // Parse the paramter of count number. > + // Parse the parameter of count number. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-n"); > if (ValueStr !=3D NULL) { > @@ -1510,7 +1510,7 @@ ShellCommandRunPing ( > SendNumber =3D DEFAULT_SEND_COUNT; > } > // > - // Parse the paramter of buffer size. > + // Parse the parameter of buffer size. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-l"); > if (ValueStr !=3D NULL) { > @@ -1532,7 +1532,7 @@ ShellCommandRunPing ( > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS)); >=20 > // > - // Parse the paramter of source ip address. > + // Parse the parameter of source ip address. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-s"); > if (ValueStr =3D=3D NULL) { > @@ -1553,7 +1553,7 @@ ShellCommandRunPing ( > } > } > // > - // Parse the paramter of destination ip address. > + // Parse the parameter of destination ip address. > // > NonOptionCount =3D ShellCommandLineGetCount(ParamPackage); > if (NonOptionCount < 2) { > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > index 90a2604..265258f 100644 > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > @@ -1177,7 +1177,7 @@ ShellCommandRunPing6 ( > BufferSize =3D 16; >=20 > // > - // Parse the paramter of count number. > + // Parse the parameter of count number. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-n"); > ValueStrPtr =3D ValueStr; > @@ -1194,7 +1194,7 @@ ShellCommandRunPing6 ( > } > } > // > - // Parse the paramter of buffer size. > + // Parse the parameter of buffer size. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-l"); > ValueStrPtr =3D ValueStr; > @@ -1215,7 +1215,7 @@ ShellCommandRunPing6 ( > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS)); >=20 > // > - // Parse the paramter of source ip address. > + // Parse the parameter of source ip address. > // > ValueStr =3D ShellCommandLineGetValue (ParamPackage, L"-s"); > ValueStrPtr =3D ValueStr; > @@ -1229,7 +1229,7 @@ ShellCommandRunPing6 ( > } > } > // > - // Parse the paramter of destination ip address. > + // Parse the parameter of destination ip address. > // > NonOptionCount =3D ShellCommandLineGetCount(ParamPackage); > ValueStr =3D ShellCommandLineGetRawValue (ParamPackage, > (UINT32)(NonOptionCount-1)); > -- > 2.10.1