From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64B431A1E29 for ; Thu, 27 Oct 2016 02:04:46 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 27 Oct 2016 02:04:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,404,1473145200"; d="scan'208,217";a="24640896" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 27 Oct 2016 02:04:45 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 02:04:45 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 02:04:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.209]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Thu, 27 Oct 2016 17:04:40 +0800 From: "Ni, Ruiyu" To: Laszlo Ersek , edk2-devel-01 Thread-Topic: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() Thread-Index: AQHSL7wC96OBITlGfk6BKefTgszd76C7b04AgACTJwA= Date: Thu, 27 Oct 2016 09:04:39 +0000 Deferred-Delivery: Thu, 27 Oct 2016 09:04:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E43EEA@SHSMSX104.ccr.corp.intel.com> References: <20161026190504.9888-1-lersek@redhat.com> <20161026190504.9888-12-lersek@redhat.com> <5951cde3-a91d-7374-9ff6-e19e9fd0b965@redhat.com> In-Reply-To: <5951cde3-a91d-7374-9ff6-e19e9fd0b965@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQwYWFhMGItYTM4Mi00MDdmLWJhMWItNjU1Yzg2ZDZhMzliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJLN0xKazJScGpTSGlrRGFWdit1eUJseUFJTVlrdUd6SDZOanJVV1E3Y2FzPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 09:04:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Regards, Ray From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Thursday, October 27, 2016 4:17 PM To: edk2-devel-01 ; Ni, Ruiyu Subject: Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE(= ) Ray, On 10/26/16 21:04, Laszlo Ersek wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > > --- > DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/D= uetBdsLib/BdsPlatform.c > index 1875dc963680..a4b2aa947322 100644 > --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > @@ -64,7 +64,7 @@ Returns: > // > // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System T= able > // > - for (Index =3D 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGu= idArray); ++Index) { > + for (Index =3D 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { > GuidHob.Raw =3D GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw= ); > if (GuidHob.Raw !=3D NULL) { > Table =3D GET_GUID_HOB_DATA (GuidHob.Guid); > I'm very sorry, I forgot to CC you on this patch originally. Can you please review it? Thank you! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel