From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] ShellPkg: Fix the coding style issue
Date: Thu, 10 Nov 2016 07:48:41 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E703D5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1478763614-16892-3-git-send-email-dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, November 10, 2016 3:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] ShellPkg: Fix the coding style issue
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Application/Shell/FileHandleWrappers.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.c
> b/ShellPkg/Application/Shell/FileHandleWrappers.c
> index 9a75a68..18f4169 100644
> --- a/ShellPkg/Application/Shell/FileHandleWrappers.c
> +++ b/ShellPkg/Application/Shell/FileHandleWrappers.c
> @@ -296,12 +296,12 @@ FileInterfaceNulWrite(
> Create the TAB completion list.
>
> @param[in] InputString The command line to expand.
> @param[in] StringLen Length of the command line.
> @param[in] BufferSize Buffer size.
> - @param[out] TabCompletionList Return the TAB completion list.
> - @param[out] TabUpdatePos Return the TAB update position.
> + @param[in, out] TabCompletionList Return the TAB completion list.
> + @param[in, out] TabUpdatePos Return the TAB update position.
> **/
> EFI_STATUS
> CreateTabCompletionList (
> IN CONST CHAR16 *InputString,
> IN CONST UINTN StringLen,
> --
> 1.9.5.msysgit.1
next prev parent reply other threads:[~2016-11-10 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 7:40 [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function Dandan Bi
2016-11-10 7:40 ` [patch] MdeModulePkg/BMMUI: add comments for function parameter Dandan Bi
2016-11-10 7:50 ` Dong, Eric
2016-11-10 7:40 ` [patch] ShellPkg: Fix the coding style issue Dandan Bi
2016-11-10 7:48 ` Ni, Ruiyu [this message]
2016-11-10 8:24 ` [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function Long, Qin
2016-11-10 8:43 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D58E703D5@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox