public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Steele, Kelly" <kelly.steele@intel.com>,
	"Wei, David" <david.wei@intel.com>,
	"Guo, Mang" <mang.guo@intel.com>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
Date: Fri, 2 Dec 2016 02:01:47 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58E912E4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20161201155326.21716-6-leif.lindholm@linaro.org>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Thursday, December 1, 2016 11:53 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Laszlo
>Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Wei,
>David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Subject: [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
>
>LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
>from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
>kept for compatibility.
>
>Since the libraries are identical, move DuetPkg to use the MdeModulePkg
>versions instead.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>---
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc  | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/DuetPkg/DuetPkgIa32.dsc b/DuetPkg/DuetPkgIa32.dsc
>index 3b59343..7dd963b 100644
>--- a/DuetPkg/DuetPkgIa32.dsc
>+++ b/DuetPkg/DuetPkgIa32.dsc
>@@ -178,7 +178,7 @@
>       gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
>       gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
>     <LibraryClasses>
>-
>DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>+      DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>
>ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
>   }
>
>@@ -211,7 +211,7 @@
>   DuetPkg/EfiLdr/EfiLdr.inf {
>     <LibraryClasses>
>       DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>-      NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>   }
>   IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
>     <LibraryClasses>
>diff --git a/DuetPkg/DuetPkgX64.dsc b/DuetPkg/DuetPkgX64.dsc
>index c23354a..1b08a95 100644
>--- a/DuetPkg/DuetPkgX64.dsc
>+++ b/DuetPkg/DuetPkgX64.dsc
>@@ -179,7 +179,7 @@
>       gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
>       gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
>     <LibraryClasses>
>-
>DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>+      DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>
>ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
>   }
>
>@@ -212,7 +212,7 @@
>   DuetPkg/EfiLdr/EfiLdr.inf {
>     <LibraryClasses>
>       DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>-      NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>+      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>   }
>   IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
>     <LibraryClasses>
>--
>2.10.2



  reply	other threads:[~2016-12-02  2:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-12-01 15:53 ` [PATCH 1/7] OvmfPkg: Remove " Leif Lindholm
2016-12-01 18:24   ` Laszlo Ersek
2016-12-01 15:53 ` [PATCH 2/7] QuarkSocPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 3/7] BeagleBoardPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 4/7] EmbeddedPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 5/7] DuetPkg: " Leif Lindholm
2016-12-02  2:01   ` Ni, Ruiyu [this message]
2016-12-01 15:53 ` [PATCH 6/7] EmulatorPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 7/7] Vlv2TbltDevicePkg: " Leif Lindholm
2016-12-05 17:32   ` Leif Lindholm
2016-12-06  6:28     ` Wei, David
2016-12-06  9:22       ` Leif Lindholm
2016-12-01 18:14 ` [PATCH 0/7] Various: Remove EDK2 " Kinney, Michael D
2016-12-01 19:38 ` Jordan Justen
2016-12-02 11:27   ` Leif Lindholm
2016-12-02 11:53     ` Laszlo Ersek
2016-12-02 12:02       ` Leif Lindholm
2016-12-02 16:13 ` Leif Lindholm
2016-12-05 15:38   ` Ard Biesheuvel
2016-12-05 16:02     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D58E912E4@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox