public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files
Date: Fri, 9 Dec 2016 01:09:05 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D58EAFAA1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1481194467-75920-9-git-send-email-dandan.bi@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Bi, Dandan
>Sent: Thursday, December 8, 2016 6:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files
>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> FatPkg/EnhancedFatDxe/Fat.inf | 2 +-
> FatPkg/FatPei/FatPei.inf      | 6 +++---
> FatPkg/FatPkg.dec             | 1 -
> FatPkg/FatPkg.dsc             | 3 +--
> 4 files changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf
>index 158f34c..e7044cd 100644
>--- a/FatPkg/EnhancedFatDxe/Fat.inf
>+++ b/FatPkg/EnhancedFatDxe/Fat.inf
>@@ -1,7 +1,7 @@
> ## @file
>-#  Component description file for FAT module.
>+#  Component Description File for FAT module.
> #
> #  This UEFI driver detects the FAT file system in the disk.
> #  It also produces the Simple File System protocol for the consumer to
> #  perform file and directory operations on the disk.
> #  Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
>diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf
>index 1409e28..273f72d 100644
>--- a/FatPkg/FatPei/FatPei.inf
>+++ b/FatPkg/FatPei/FatPei.inf
>@@ -59,13 +59,13 @@ [Guids]
>   gRecoveryOnFatIdeDiskGuid                   ## SOMETIMES_CONSUMES   ## UNDEFINED
>   gRecoveryOnFatFloppyDiskGuid                ## SOMETIMES_CONSUMES   ## UNDEFINED
>
>
> [Ppis]
>-  gEfiPeiVirtualBlockIoPpiGuid                  # PPI_NOTIFY SOMETIMES_CONSUMED
>-  gEfiPeiVirtualBlockIo2PpiGuid                 # PPI_NOTIFY SOMETIMES_CONSUMED
>-  gEfiPeiDeviceRecoveryModulePpiGuid            # SOMETIMES_PRODUCED
>+  gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES PPI_NOTIFY
>+  gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES PPI_NOTIFY
>+  gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
>
>
> [FeaturePcd]
>   gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport         ## CONSUMES
>
>diff --git a/FatPkg/FatPkg.dec b/FatPkg/FatPkg.dec
>index e898d95..8bdddb1 100644
>--- a/FatPkg/FatPkg.dec
>+++ b/FatPkg/FatPkg.dec
>@@ -1,7 +1,6 @@
> ## @file
>-#
> #  FAT Package
> #
> #  FAT 32 Driver
> #  Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
> #
>diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc
>index d654120..841201c 100644
>--- a/FatPkg/FatPkg.dsc
>+++ b/FatPkg/FatPkg.dsc
>@@ -1,8 +1,7 @@
> ## @file
>-#
>-#  Build Binary Enhanced Fat Driver Modules
>+#  Build Binary Enhanced Fat Driver Modules.
> #
> #  This Platform file is used to generate the Binary Fat Drivers
> #  for EDK II Prime release.
> #  Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
> #
>--
>1.9.5.msysgit.1



      reply	other threads:[~2016-12-09  1:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 10:54 [patch 0/8] FatPkg: Fix coding style issues Dandan Bi
2016-12-08 10:54 ` [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean Dandan Bi
2016-12-09  1:14   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration Dandan Bi
2016-12-08 17:27   ` Kurt Kennett
2016-12-08 23:11     ` Andrew Fish
2016-12-20 23:26       ` Brian J. Johnson
2016-12-08 23:47     ` Yao, Jiewen
2016-12-09  0:26       ` Kurt Kennett
2016-12-09  0:36         ` Andrew Fish
2016-12-09  0:40           ` Yao, Jiewen
2016-12-09 16:32             ` Kurt Kennett
2016-12-09  0:40           ` Kurt Kennett
2016-12-09  0:57   ` Ni, Ruiyu
2016-12-09  1:18     ` Bi, Dandan
2016-12-08 10:54 ` [patch 3/8] FatPkg\EnhancedFatDxe: Make function prototype align with definition Dandan Bi
2016-12-09  1:13   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 4/8] FatPkg\EnhancedFatDxe: Make the variable name follow rule Dandan Bi
2016-12-09  1:12   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 5/8] FatPkg\EnhancedFatDxe: Use typedef for complex type Dandan Bi
2016-12-09  1:11   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 6/8] FatPkg\EnhancedFatDxe: Make the comments align with EDKII coding style Dandan Bi
2016-12-09  1:10   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 7/8] FatPkg\EnhancedFatDxe: Add comments for functions Dandan Bi
2016-12-09  1:10   ` Ni, Ruiyu
2016-12-08 10:54 ` [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files Dandan Bi
2016-12-09  1:09   ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D58EAFAA1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox