Re: [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Bi, Dandan
>Sent: Thursday, December 8, 2016 6:54 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean
>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> FatPkg/EnhancedFatDxe/FileName.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/FileName.c
>index 5df4036..f393aa6 100644
>--- a/FatPkg/EnhancedFatDxe/FileName.c
>+++ b/FatPkg/EnhancedFatDxe/FileName.c
>@@ -57,11 +57,11 @@ Returns:
>   UINTN   ExtendNameLen;
>
>   PossibleShortName = TRUE;
>   SeparateDot       = NULL;
>   SetMem (File8Dot3Name, FAT_NAME_LEN, ' ');
>-  for (TempName = FileName; *TempName; TempName++) {
>+  for (TempName = FileName; *TempName != '\0'; TempName++) {
>     if (*TempName == L'.') {
>       SeparateDot = TempName;
>     }
>   }
>
>@@ -451,11 +451,11 @@ Returns:
> {
>   UINTN ShortNameLen;
>   UINT8 Sum;
>   Sum = 0;
>   for (ShortNameLen = FAT_NAME_LEN; ShortNameLen != 0; ShortNameLen--) {
>-    Sum = (UINT8)(((Sum & 1) ? 0x80 : 0) + (Sum >> 1) + *ShortNameString++);
>+    Sum = (UINT8)((((Sum & 1) != 0) ? 0x80 : 0) + (Sum >> 1) + *ShortNameString++);
>   }
>
>   return Sum;
> }
>
>--
>1.9.5.msysgit.1