From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9D1E281F91 for ; Thu, 8 Dec 2016 17:35:16 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 08 Dec 2016 17:35:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,322,1477983600"; d="scan'208,217";a="40671525" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 08 Dec 2016 17:35:16 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Dec 2016 17:35:15 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Dec 2016 17:35:15 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Fri, 9 Dec 2016 09:35:12 +0800 From: "Ni, Ruiyu" To: "Carsey, Jaben" , Tapan Shah , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command Thread-Index: AQHSUZ9suuV3hN+hI0iV/BaxJuQE+aD+1axg Date: Fri, 9 Dec 2016 01:35:13 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D58EAFD1F@SHSMSX104.ccr.corp.intel.com> References: <1481217671-10440-1-git-send-email-tapandshah@hpe.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTcyZjdmY2QtNDkwZC00Yzk2LTk3NzYtOTYxYzY3MGFkNDM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFkc1dRa1o0b0RYdUl3WGJENTIyTnYxNGlxeFRjUlMwTDZsZjUyZklNM1k9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 01:35:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable done. Regards, Ray From: Carsey, Jaben Sent: Friday, December 9, 2016 6:07 AM To: Tapan Shah ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben Subject: RE: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls= ' command Reviewed-by: Jaben Carsey > Ray, can you push with your other stuff? > -----Original Message----- > From: Tapan Shah [mailto:tapandshah@hpe.com] > Sent: Thursday, December 8, 2016 9:21 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben >= ; Tapan Shah > > > Subject: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' = command > Importance: High > > Adding a missing header line for 'cls -sfo' command > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah > > --- > ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c = | 1 + > .../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni = | 1 > + > 2 files changed, 2 insertions(+) > > diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > index de79b82..7e7d58d 100644 > --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c > @@ -82,6 +82,7 @@ ShellCommandRunCls ( > } else { > Background =3D (gST->ConOut->Mode->Attribute >> 4) & 0x7; > Foreground =3D gST->ConOut->Mode->Attribute & 0x0F; > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER)= , > gShellLevel3HiiHandle, L"cls"); > ShellPrintHiiEx ( > -1, > -1, > diff --git > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > index bbcb752..b027c67 100644 > --- > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > +++ > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib. > uni > @@ -43,6 +43,7 @@ > #string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not > found - '%H%s%N'\r\n" > #string STR_GEN_FILE_NF #language en-US "%H%s%N: File not foun= d - > '%H%s%N'\r\n" > #string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a > directory\r\n" > +#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n= " > #string STR_NO_SCRIPT #language en-US "The command '%H%s%N' = is > not allowed outside of a script\r\n" > > #string STR_TYP_ERROR #language en-US "%H%s%N: Operation was= not > successful on '%H%s%N'\r\n" > -- > 1.9.5.msysgit.0