public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule
Date: Fri, 16 Dec 2016 04:59:46 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B832B69@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1481855136-115456-3-git-send-email-dandan.bi@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Bi, Dandan
>Sent: Friday, December 16, 2016 10:26 AM
>To: edk2-devel@lists.01.org
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule
>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c  | 2 +-
> .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c   | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
>b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
>index 876e99f..3e9ff66 100644
>--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
>+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
>@@ -21,11 +21,11 @@ EFI_CPU_ARCH_PROTOCOL      *mCpu;
> //
> // We only support the following device types
> //
> STATIC
> CONST EFI_GUID * CONST
>-SupportedNonDiscoverableDevices [] = {
>+SupportedNonDiscoverableDevices[] = {
>   &gEdkiiNonDiscoverableAhciDeviceGuid,
>   &gEdkiiNonDiscoverableEhciDeviceGuid,
>   &gEdkiiNonDiscoverableNvmeDeviceGuid,
>   &gEdkiiNonDiscoverableOhciDeviceGuid,
>   &gEdkiiNonDiscoverableSdhciDeviceGuid,
>diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
>b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
>index 1ffbdfa..b07c129 100644
>--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
>+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
>@@ -1298,11 +1298,12 @@ PciIoGetBarAttributes (
>   OUT UINT64                         *Supports OPTIONAL,
>   OUT VOID                           **Resources OPTIONAL
>   )
> {
>   NON_DISCOVERABLE_PCI_DEVICE       *Dev;
>-  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor, *BarDesc;
>+  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
>+  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *BarDesc;
>   EFI_ACPI_END_TAG_DESCRIPTOR       *End;
>   EFI_STATUS                        Status;
>
>   if (Supports == NULL && Resources == NULL) {
>     return EFI_INVALID_PARAMETER;
>--
>1.9.5.msysgit.1



  reply	other threads:[~2016-12-16  4:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  2:25 [patch 1/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: Fix VS2010/2012 build failure Dandan Bi
2016-12-16  2:25 ` [patch 2/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add comments for functions Dandan Bi
2016-12-16  4:59   ` Ni, Ruiyu
2016-12-16  2:25 ` [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule Dandan Bi
2016-12-16  4:59   ` Ni, Ruiyu [this message]
2016-12-16  4:59 ` [patch 1/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: Fix VS2010/2012 build failure Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B832B69@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox