From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F5FC82030 for ; Thu, 15 Dec 2016 20:59:52 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 15 Dec 2016 20:59:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,355,1477983600"; d="scan'208";a="18806260" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 15 Dec 2016 20:59:51 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 15 Dec 2016 20:59:51 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 15 Dec 2016 20:59:51 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.77]) with mapi id 14.03.0248.002; Fri, 16 Dec 2016 12:59:48 +0800 From: "Ni, Ruiyu" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: Ard Biesheuvel Thread-Topic: [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule Thread-Index: AQHSV0O+/KduYcPBh0ul5EwcbmZVlKEKA6hQ Date: Fri, 16 Dec 2016 04:59:46 +0000 Deferred-Delivery: Fri, 16 Dec 2016 04:59:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B832B69@SHSMSX103.ccr.corp.intel.com> References: <1481855136-115456-1-git-send-email-dandan.bi@intel.com> <1481855136-115456-3-git-send-email-dandan.bi@intel.com> In-Reply-To: <1481855136-115456-3-git-send-email-dandan.bi@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGI4MGEyNzQtOTAwYi00ZjAzLThkNzEtYjRhNmYwMGE2OTdjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJyMHhJdVdyODluVFE0NHl3aGthdzZZMWFOVjJRVlExV1phUTRyXC9ENnM5cz0ifQ== x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2016 04:59:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Regards, Ray >-----Original Message----- >From: Bi, Dandan >Sent: Friday, December 16, 2016 10:26 AM >To: edk2-devel@lists.01.org >Cc: Ard Biesheuvel ; Ni, Ruiyu >Subject: [patch 3/3] MdeModulePkg/NonDiscoverablePciDevice: Make variable = definition follow rule > >Cc: Ard Biesheuvel >Cc: Ruiyu Ni >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Dandan Bi >--- > .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c | = 2 +- > .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | = 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscovera= blePciDeviceDxe.c >b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDevic= eDxe.c >index 876e99f..3e9ff66 100644 >--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD= eviceDxe.c >+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD= eviceDxe.c >@@ -21,11 +21,11 @@ EFI_CPU_ARCH_PROTOCOL *mCpu; > // > // We only support the following device types > // > STATIC > CONST EFI_GUID * CONST >-SupportedNonDiscoverableDevices [] =3D { >+SupportedNonDiscoverableDevices[] =3D { > &gEdkiiNonDiscoverableAhciDeviceGuid, > &gEdkiiNonDiscoverableEhciDeviceGuid, > &gEdkiiNonDiscoverableNvmeDeviceGuid, > &gEdkiiNonDiscoverableOhciDeviceGuid, > &gEdkiiNonDiscoverableSdhciDeviceGuid, >diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscovera= blePciDeviceIo.c >b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDevic= eIo.c >index 1ffbdfa..b07c129 100644 >--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD= eviceIo.c >+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD= eviceIo.c >@@ -1298,11 +1298,12 @@ PciIoGetBarAttributes ( > OUT UINT64 *Supports OPTIONAL, > OUT VOID **Resources OPTIONAL > ) > { > NON_DISCOVERABLE_PCI_DEVICE *Dev; >- EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor, *BarDesc; >+ EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor; >+ EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *BarDesc; > EFI_ACPI_END_TAG_DESCRIPTOR *End; > EFI_STATUS Status; > > if (Supports =3D=3D NULL && Resources =3D=3D NULL) { > return EFI_INVALID_PARAMETER; >-- >1.9.5.msysgit.1