From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Michael Zimmermann <sigmaepsilon92@gmail.com>,
"Fan, Jeff" <jeff.fan@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 0/5] Execute key notify function at TPL_CALLBACK
Date: Fri, 23 Dec 2016 07:11:30 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8622F8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1482414310-33036-1-git-send-email-star.zeng@intel.com>
Star,
I checked all your patches.
My comments to Patch 1/5 also apply to your other patches.
Regards,
Ray
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star Zeng
>Sent: Thursday, December 22, 2016 9:45 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Tian, Feng <feng.tian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
>Michael Zimmermann <sigmaepsilon92@gmail.com>; Fan, Jeff <jeff.fan@intel.com>; Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK
>
>Current implementation of keyboard driver executes key notify
>function in TimerHandler at TPL_NOTIFY. The code change is to
>make key notify function executed at TPL_CALLBACK to reduce
>the time occupied at TPL_NOTIFY.
>
>The code will signal KeyNotify process event if the key pressed
>matches any key registered and insert the KeyData to the EFI Key
>queue for notify, then the KeyNotify process handler will invoke
>key notify functions at TPL_CALLBACK.
>
>It can also address the problem raised at
>https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html
>
>Cc: Ruiyu Ni <Ruiyu.ni@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Feng Tian <feng.tian@intel.com>
>Cc: Jeff Fan <jeff.fan@intel.com>
>Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>
>
>Star Zeng (5):
> MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK
> MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK
> MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK
> IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at
> TPL_CALLBACK
> IntelFrameworkModulePkg KbDxe: Execute key notify func at TPL_CALLBACK
>
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 9 +-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 47 +++++-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 23 ++-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 75 ++++++++-
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 17 +-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 7 +-
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 45 ++++++
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 20 +++
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 64 +++++++-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 17 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 10 +-
> .../Universal/Console/TerminalDxe/Terminal.c | 25 ++-
> .../Universal/Console/TerminalDxe/Terminal.h | 80 +++++++++-
> .../Universal/Console/TerminalDxe/TerminalConIn.c | 177 ++++++++++++++++++++-
> 16 files changed, 622 insertions(+), 24 deletions(-)
>
>--
>2.7.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-12-23 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 13:45 [PATCH 0/5] Execute key notify function at TPL_CALLBACK Star Zeng
2016-12-22 13:45 ` [PATCH 1/5] MdeModulePkg UsbKbDxe: Execute key notify func " Star Zeng
2016-12-23 7:01 ` Ni, Ruiyu
2016-12-23 7:05 ` Zeng, Star
2016-12-23 7:09 ` Ni, Ruiyu
2016-12-23 7:28 ` Zeng, Star
2016-12-22 13:45 ` [PATCH 2/5] MdeModulePkg TerminalDxe: " Star Zeng
2016-12-22 13:45 ` [PATCH 3/5] MdeModulePkg Ps2KbDxe: " Star Zeng
2016-12-22 13:45 ` [PATCH 4/5] IntelFrameworkModulePkg " Star Zeng
2016-12-23 2:16 ` Fan, Jeff
2016-12-22 13:45 ` [PATCH 5/5] IntelFrameworkModulePkg KbDxe: " Star Zeng
2016-12-23 2:16 ` Fan, Jeff
2016-12-23 7:11 ` Ni, Ruiyu [this message]
2016-12-23 8:14 ` [PATCH 0/5] Execute key notify function " Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B8622F8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox