From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7FDB782406 for ; Thu, 22 Dec 2016 23:11:36 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 22 Dec 2016 23:11:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,392,1477983600"; d="scan'208";a="1075516362" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 22 Dec 2016 23:11:35 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Dec 2016 23:11:34 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Dec 2016 23:11:34 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Fri, 23 Dec 2016 15:11:30 +0800 From: "Ni, Ruiyu" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Kinney, Michael D" , Michael Zimmermann , "Fan, Jeff" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK Thread-Index: AQHSXFmkVzpaxHrHokeGHvfeG+SBKqEVHqbA Date: Fri, 23 Dec 2016 07:11:30 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8622F8@SHSMSX104.ccr.corp.intel.com> References: <1482414310-33036-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1482414310-33036-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjA0OWM3M2ItOWQxYS00YTkzLTgyYjQtYTE1ZGI3N2FhODhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5sdHZIMjJsRnFmNEhFTHl6em9xcTJqdHJHS1duTTJEQ0s5Rnh1UjUzc009In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Execute key notify function at TPL_CALLBACK X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 07:11:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, I checked all your patches. My comments to Patch 1/5 also apply to your other patches. Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sta= r Zeng >Sent: Thursday, December 22, 2016 9:45 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Tian, Feng ; Kinn= ey, Michael D ; >Michael Zimmermann ; Fan, Jeff ; Zeng, Star >Subject: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK > >Current implementation of keyboard driver executes key notify >function in TimerHandler at TPL_NOTIFY. The code change is to >make key notify function executed at TPL_CALLBACK to reduce >the time occupied at TPL_NOTIFY. > >The code will signal KeyNotify process event if the key pressed >matches any key registered and insert the KeyData to the EFI Key >queue for notify, then the KeyNotify process handler will invoke >key notify functions at TPL_CALLBACK. > >It can also address the problem raised at >https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html > >Cc: Ruiyu Ni >Cc: Michael Kinney >Cc: Feng Tian >Cc: Jeff Fan >Cc: Michael Zimmermann > >Star Zeng (5): > MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK > IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at > TPL_CALLBACK > IntelFrameworkModulePkg KbDxe: Execute key notify func at TPL_CALLBACK > > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 9 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 47 +++++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 23 ++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 75 ++++++++- > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 17 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 7 +- > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 45 ++++++ > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 20 +++ > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 64 +++++++- > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 17 +- > MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 10 +- > .../Universal/Console/TerminalDxe/Terminal.c | 25 ++- > .../Universal/Console/TerminalDxe/Terminal.h | 80 +++++++++- > .../Universal/Console/TerminalDxe/TerminalConIn.c | 177 ++++++++++++++++= ++++- > 16 files changed, 622 insertions(+), 24 deletions(-) > >-- >2.7.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel