Re: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, December 23, 2016 4:13 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
>Tian, Feng <feng.tian@intel.com>; Fan, Jeff <jeff.fan@intel.com>; Michael Zimmermann <sigmaepsilon92@gmail.com>
>Subject: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK
>
>Current implementation of keyboard driver executes key notify
>function in TimerHandler at TPL_NOTIFY. The code change is to
>make key notify function executed at TPL_CALLBACK to reduce
>the time occupied at TPL_NOTIFY.
>
>The code will signal KeyNotify process event if the key pressed
>matches any key registered and insert the KeyData to the EFI Key
>queue for notify, then the KeyNotify process handler will invoke
>key notify functions at TPL_CALLBACK.
>
>It can also address the problem raised at
>https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html
>
>V2:
>Based on the comments from Ruiyu, Ni,
>add comments before calling Enqueue() to make the code more clear
>and eliminate the call to IsQueueEmpty() in KeyNotifyProcessHandler().
>
>Cc: Ruiyu Ni <Ruiyu.ni@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Cc: Feng Tian <feng.tian@intel.com>
>Cc: Jeff Fan <jeff.fan@intel.com>
>Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>
>
>Star Zeng (5):
>  MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK
>  MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK
>  MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK
>  IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at
>    TPL_CALLBACK
>  IntelFrameworkModulePkg KbDxe: Execute key notify func at TPL_CALLBACK
>
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c         |  14 +-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c          |  51 +++++-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c           |  23 ++-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h           |  15 ++
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c       |  86 +++++++++-
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h       |  17 +-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c         |  12 +-
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c |  49 ++++++
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c  |  20 +++
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h  |  15 ++
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c             |  68 +++++++-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h             |  17 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c           |  12 +-
> .../Universal/Console/TerminalDxe/Terminal.c       |  25 ++-
> .../Universal/Console/TerminalDxe/Terminal.h       |  80 ++++++++-
> .../Universal/Console/TerminalDxe/TerminalConIn.c  | 186 ++++++++++++++++++++-
> 16 files changed, 665 insertions(+), 25 deletions(-)
>
>--
>2.7.0.windows.1