From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC29E8234B for ; Fri, 23 Dec 2016 01:51:32 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 23 Dec 2016 01:51:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,392,1477983600"; d="scan'208";a="1103384658" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 23 Dec 2016 01:51:32 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Dec 2016 01:51:32 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Dec 2016 01:51:31 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Fri, 23 Dec 2016 17:51:28 +0800 From: "Ni, Ruiyu" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Tian, Feng" , "Fan, Jeff" , Michael Zimmermann Thread-Topic: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK Thread-Index: AQHSXPR1GcuQhDxdv0+M13vYKOezO6EVSfvw Date: Fri, 23 Dec 2016 09:51:27 +0000 Deferred-Delivery: Fri, 23 Dec 2016 09:51:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B862630@SHSMSX104.ccr.corp.intel.com> References: <1482480792-35264-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1482480792-35264-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJmMDNkZTktZjIxYS00N2FmLTk3NjctMTExYTlmNGRkZjljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJuRm0zUllPa2ZsdGMzRjZkc0RSV2JKdVwvRGt5YllDNkF1UytoUlBLZkxsbz0ifQ== x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 09:51:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Regards, Ray >-----Original Message----- >From: Zeng, Star >Sent: Friday, December 23, 2016 4:13 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Ni, Ruiyu ; Kinn= ey, Michael D ; >Tian, Feng ; Fan, Jeff ; Michael = Zimmermann >Subject: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK > >Current implementation of keyboard driver executes key notify >function in TimerHandler at TPL_NOTIFY. The code change is to >make key notify function executed at TPL_CALLBACK to reduce >the time occupied at TPL_NOTIFY. > >The code will signal KeyNotify process event if the key pressed >matches any key registered and insert the KeyData to the EFI Key >queue for notify, then the KeyNotify process handler will invoke >key notify functions at TPL_CALLBACK. > >It can also address the problem raised at >https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html > >V2: >Based on the comments from Ruiyu, Ni, >add comments before calling Enqueue() to make the code more clear >and eliminate the call to IsQueueEmpty() in KeyNotifyProcessHandler(). > >Cc: Ruiyu Ni >Cc: Michael Kinney >Cc: Feng Tian >Cc: Jeff Fan >Cc: Michael Zimmermann > >Star Zeng (5): > MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK > IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at > TPL_CALLBACK > IntelFrameworkModulePkg KbDxe: Execute key notify func at TPL_CALLBACK > > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 14 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 51 +++++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 23 ++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 86 +++++++++- > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 17 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 12 +- > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 49 ++++++ > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 20 +++ > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 68 +++++++- > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 17 +- > MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 12 +- > .../Universal/Console/TerminalDxe/Terminal.c | 25 ++- > .../Universal/Console/TerminalDxe/Terminal.h | 80 ++++++++- > .../Universal/Console/TerminalDxe/TerminalConIn.c | 186 ++++++++++++++++= ++++- > 16 files changed, 665 insertions(+), 25 deletions(-) > >-- >2.7.0.windows.1