public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg/UefiBootManagerLib: Remove redundant type cast
Date: Fri, 6 Jan 2017 08:54:06 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B87670D@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1483692781-24460-1-git-send-email-hao.a.wu@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Regards,
Ray

>-----Original Message-----
>From: Wu, Hao A
>Sent: Friday, January 6, 2017 4:53 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Remove redundant type cast
>
>The type of return value for function EfiBootManagerFindLoadOption() is
>INTN. When checking its return value, it is unnecessary to type cast -1 to
>type UINTN.
>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Hao Wu <hao.a.wu@intel.com>
>---
> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
>b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
>index 6b84b85..75bd5dc 100644
>--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
>+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
>@@ -1,7 +1,7 @@
> /** @file
>   Library functions which relates with booting.
>
>-Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
>+Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
>@@ -2152,7 +2152,7 @@ EfiBootManagerRefreshAllBootOption (
>       // Only check those added by BDS
>       // so that the boot options added by end-user or OS installer won't be deleted
>       //
>-      if (EfiBootManagerFindLoadOption (&NvBootOptions[Index], BootOptions, BootOptionCount) == (UINTN) -1) {
>+      if (EfiBootManagerFindLoadOption (&NvBootOptions[Index], BootOptions, BootOptionCount) == -1) {
>         Status = EfiBootManagerDeleteLoadOptionVariable (NvBootOptions[Index].OptionNumber, LoadOptionTypeBoot);
>         //
>         // Deleting variable with current variable implementation shouldn't fail.
>@@ -2166,7 +2166,7 @@ EfiBootManagerRefreshAllBootOption (
>   // Add new EFI boot options to NV
>   //
>   for (Index = 0; Index < BootOptionCount; Index++) {
>-    if (EfiBootManagerFindLoadOption (&BootOptions[Index], NvBootOptions, NvBootOptionCount) == (UINTN) -1) {
>+    if (EfiBootManagerFindLoadOption (&BootOptions[Index], NvBootOptions, NvBootOptionCount) == -1) {
>       EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], (UINTN) -1);
>       //
>       // Try best to add the boot options so continue upon failure.
>--
>1.9.5.msysgit.0



  reply	other threads:[~2017-01-06  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06  8:53 [PATCH] MdeModulePkg/UefiBootManagerLib: Remove redundant type cast Hao Wu
2017-01-06  8:54 ` Ni, Ruiyu [this message]
2017-01-06  9:04 ` Wang, Sunny (HPS SW)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B87670D@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox