public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter
Date: Tue, 10 Jan 2017 02:23:47 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B879990@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515C54B3DE11@FMSMSX103.amr.corp.intel.com>

Jaben,
Yes we will add the API to convert string to GUID. After the library API is added, the local implementation will be removed.

Thanks/Ray

> -----Original Message-----
> From: Carsey, Jaben
> Sent: Monday, January 9, 2017 11:41 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: RE: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID
> and "decode" parameter
> 
> Looks good.
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
> I had one inline question.
> 
> I would also propose that the String to GUID conversion be placed in a shared
> library.  Maybe even baselib with the other string functions?
> 
> Mike, do you have any thoughts on StringToGuid conversion?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Ruiyu Ni
> > Sent: Monday, January 9, 2017 1:31 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and
> > "decode" parameter
> > Importance: High
> >
> > Change "dh" to support dump from GUID and "decode" parameter
> >
> > Chen A Chen (2):
> >   ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids
> >   ShellPkg/Dh: Fix coding style issues
> >
> > Ruiyu Ni (3):
> >   ShellPkg/HandleParsingLib: Rename global variables
> >   ShellPkg/HandleParsingLib: Return NULL name for unknown GUID
> >   ShellPkg/dh: Support dump from GUID and "decode" parameter
> >
> >  ShellPkg/Include/Library/HandleParsingLib.h        |  21 +-
> >  .../UefiHandleParsingLib/UefiHandleParsingLib.c    | 130 ++++--
> >  .../UefiHandleParsingLib/UefiHandleParsingLib.uni  |   4 +-
> >  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c  | 458
> > +++++++++++++++--
> > ----
> >  .../UefiShellDriver1CommandsLib.uni                |   9 +-
> >  5 files changed, 446 insertions(+), 176 deletions(-)
> >
> > --
> > 2.9.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-01-10  2:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09  9:30 [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter Ruiyu Ni
2017-01-09  9:30 ` [PATCH 1/5] ShellPkg/HandleParsingLib: Rename global variables Ruiyu Ni
2017-01-09  9:30 ` [PATCH 2/5] ShellPkg/HandleParsingLib: Return NULL name for unknown GUID Ruiyu Ni
2017-01-09  9:30 ` [PATCH 3/5] ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids Ruiyu Ni
2017-01-09  9:30 ` [PATCH 4/5] ShellPkg/Dh: Fix coding style issues Ruiyu Ni
2017-01-09 15:36   ` Carsey, Jaben
2017-01-10  2:24     ` Ni, Ruiyu
2017-01-10 16:20       ` Carsey, Jaben
2017-01-09  9:30 ` [PATCH 5/5] ShellPkg/dh: Support dump from GUID and "decode" parameter Ruiyu Ni
2017-01-09 15:40 ` [PATCH 0/5] Change "dh" to support " Carsey, Jaben
2017-01-10  2:23   ` Ni, Ruiyu [this message]
2017-01-10 21:43     ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B879990@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox