From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DFCD81EE6 for ; Mon, 23 Jan 2017 22:56:57 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 23 Jan 2017 22:56:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,277,1477983600"; d="scan'208";a="812565359" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jan 2017 22:56:56 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 23 Jan 2017 22:56:56 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Tue, 24 Jan 2017 14:56:54 +0800 From: "Ni, Ruiyu" To: Tim Lewis , "Carsey, Jaben" , "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 Thread-Index: AQHSdIgPSOnz/s3vkk6qjq+iA01goaFEMZTg//+CBwCAAIy+4IABkCkAgAA1YYCAAS7UsA== Date: Tue, 24 Jan 2017 06:56:53 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B88842C@SHSMSX104.ccr.corp.intel.com> References: <1485073063-211620-1-git-send-email-star.zeng@intel.com> <1485073063-211620-4-git-send-email-star.zeng@intel.com> <734D49CCEBEEF84792F5B80ED585239D5B886249@SHSMSX104.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B818FBB@shsmsx102.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5B8862A7@SHSMSX104.ccr.corp.intel.com> <7236196A5DF6C040855A6D96F556A53F424B32@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53F424B32@msmail.insydesw.com.tw> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 06:56:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Tim, I agree with you. If the text to display has to be in English. Embedding them in C file makes= code more readable. Thanks/Ray > -----Original Message----- > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Tuesday, January 24, 2017 4:52 AM > To: Carsey, Jaben ; Ni, Ruiyu ; > Zeng, Star ; edk2-devel@lists.01.org > Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS > spec 3.1.1 >=20 > Also, in some cases, the text is taken directly from the specification. > Introducing HII strings in order to make these translatable when the sour= ce > material is normative doesn't help, IMO. >=20 > Tim >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Monday, January 23, 2017 9:41 AM > To: Ni, Ruiyu ; Zeng, Star ; edk= 2- > devel@lists.01.org > Cc: Carsey, Jaben > Subject: Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of > SMBIOS spec 3.1.1 >=20 > Reviewed-by: Jaben Carsey >=20 > I think that string mixed use existed in the EDK version of the command a= nd > was just never removed. >=20 > -Jaben >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Sunday, January 22, 2017 1:49 AM > > To: Zeng, Star ; edk2-devel@lists.01.org > > Cc: Carsey, Jaben > > Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS > > spec 3.1.1 > > Importance: High > > > > Reviewed-by: Ruiyu Ni > > > > Thanks/Ray > > > > > -----Original Message----- > > > From: Zeng, Star > > > Sent: Sunday, January 22, 2017 5:25 PM > > > To: Ni, Ruiyu ; edk2-devel@lists.01.org > > > Cc: Carsey, Jaben ; Zeng, Star > > > > > > Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS > > > spec 3.1.1 > > > > > > Ray & Jaben, > > > > > > I am not so sure about the rule. > > > The mixed using of strings in c code and strings in uni file has > > > been there since it was created. > > > > > > > > > Thanks, > > > Star > > > -----Original Message----- > > > From: Ni, Ruiyu > > > Sent: Sunday, January 22, 2017 4:56 PM > > > To: Zeng, Star ; edk2-devel@lists.01.org > > > Cc: Carsey, Jaben > > > Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS > > > spec 3.1.1 > > > > > > Star, > > > Why some strings are hardcoded in C file while some are defined in > > > UNI > > file? > > > What's the rule? > > > > > > Thanks/Ray > > > > > > > -----Original Message----- > > > > From: Zeng, Star > > > > Sent: Sunday, January 22, 2017 4:18 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Zeng, Star ; Ni, Ruiyu > > > > ; Carsey, Jaben > > > > Subject: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS > > spec > > > > 3.1.1 > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D349 > > > > > > > > Cc: Ruiyu Ni > > > > Cc: Jaben Carsey > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: Star Zeng > > > > --- > > > > .../SmbiosView/PrintInfo.c | 6 +++- > > > > .../SmbiosView/QueryTable.c | 37 > > ++++++++++++++++++++++ > > > > .../SmbiosView/QueryTable.h | 14 +++++++- > > > > .../SmbiosView/SmbiosViewStrings.uni | 3 +- > > > > 4 files changed, 57 insertions(+), 3 deletions(-) > > > > > > > > diff --git > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > > > index ecb8e2492453..1d6002b92593 100644 > > > > --- > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > > > +++ > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > > > @@ -1106,7 +1106,7 @@ SmbiosPrintStructure ( > > > > // Management Controller Host Interface (Type 42) > > > > // > > > > case 42: > > > > - PRINT_STRUCT_VALUE_H (Struct, Type42, InterfaceType); > > > > + DisplayMCHostInterfaceType (Struct->Type42->InterfaceType, > > > > + Option); > > > > break; > > > > > > > > // > > > > @@ -1818,6 +1818,10 @@ DisplayProcessorFamily ( > > > > Print (L"AMD Opteron(TM) X3000 Series APU\n"); > > > > break; > > > > > > > > + case 0x6B: > > > > + Print (L"AMD Zen Processor Family\n"); > > > > + break; > > > > + > > > > case 0x70: > > > > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > > > > (STR_SMBIOSVIEW_PRINTINFO_HOBBIT_FAMILY), > > gShellDebug1HiiHandle); > > > > break; > > > > diff --git > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > c > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > c > > > > index 4a06c12e3b2b..282ba584c8c9 100644 > > > > --- > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > c > > > > +++ > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > +++ c > > > > @@ -575,6 +575,10 @@ TABLE_ITEM ProcessorUpgradeTable[] =3D { > > > > { > > > > 0x37, > > > > L"Socket SP3" > > > > + }, > > > > + { > > > > + 0x38, > > > > + L"Socket SP3r2" > > > > } > > > > }; > > > > > > > > @@ -3156,6 +3160,22 @@ TABLE_ITEM > IPMIDIBMCInterfaceTypeTable[] > > =3D > > > { > > > > }, > > > > }; > > > > > > > > +TABLE_ITEM MCHostInterfaceTypeTable[] =3D { > > > > + { > > > > + 0x3F00, > > > > + L" MCTP Host Interface " > > > > + }, > > > > + { > > > > + 0x40, > > > > + L" Network Host Interface " > > > > + }, > > > > + { > > > > + 0xF0, > > > > + L" OEM defined " > > > > + }, > > > > +}; > > > > + > > > > + > > > > TABLE_ITEM StructureTypeInfoTable[] =3D { > > > > { > > > > 0, > > > > @@ -4525,6 +4545,23 @@ DisplayIPMIDIBMCInterfaceType ( } > > > > > > > > /** > > > > + Display Management Controller Host Interface (Type 42) informati= on. > > > > + > > > > + @param[in] Key The key of the structure. > > > > + @param[in] Option The optional information. > > > > +**/ > > > > +VOID > > > > +DisplayMCHostInterfaceType ( > > > > + IN UINT8 Key, > > > > + IN UINT8 Option > > > > + ) > > > > +{ > > > > + ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > > > > +(STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), > > > > +gShellDebug1HiiHandle); > > > > + PRINT_INFO_OPTION (Key, Option); > > > > + PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } > > > > + > > > > +/** > > > > Display the structure type information. > > > > > > > > @param[in] Key The key of the structure. > > > > diff --git > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > h > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > h > > > > index 9cae7094fb19..bd9e6898d40a 100644 > > > > --- > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > h > > > > +++ > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > > > +++ h > > > > @@ -2,7 +2,7 @@ > > > > Build a table, each item is (key, info) pair. > > > > and give a interface of query a string out of a table. > > > > > > > > - Copyright (c) 2005 - 2012, Intel Corporation. All rights > > > > reserved.
> > > > + Copyright (c) 2005 - 2017, Intel Corporation. All rights > > > > + reserved.
> > > > This program and the accompanying materials > > > > are licensed and made available under the terms and conditions > > > > of the BSD License > > > > which accompanies this distribution. The full text of the > > > > license may be found at @@ -779,4 +779,16 @@ > > DisplayIPMIDIBMCInterfaceType ( > > > > IN UINT8 Option > > > > ); > > > > > > > > +/** > > > > + Display Management Controller Host Interface (Type 42) informati= on. > > > > + > > > > + @param[in] Key The key of the structure. > > > > + @param[in] Option The optional information. > > > > +**/ > > > > +VOID > > > > +DisplayMCHostInterfaceType ( > > > > + IN UINT8 Key, > > > > + IN UINT8 Option > > > > + ); > > > > + > > > > #endif > > > > diff --git > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > > > > Strings.uni > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > > > > Strings.uni > > > > index b9032df076d2..7d694536dbcd 100644 > > > > --- > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > > > > Strings.uni > > > > +++ > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView > > > > S > > > > +++ trings.uni > > > > @@ -1,6 +1,6 @@ > > > > // /** > > > > // > > > > -// Copyright (c) 2005 - 2015, Intel Corporation. All rights > > > > reserved.
> > > > +// Copyright (c) 2005 - 2017, Intel Corporation. All rights > > > > +reserved.
> > > > // (C) Copyright 2014-2015 Hewlett-Packard Development Company, > > > > L.P.
// (C) Copyright 2015-2017 Hewlett Packard Enterprise > > > > Development LP
// This program and the accompanying materials > > @@ > > > > -444,6 +444,7 @@ #string > > > > STR_SMBIOSVIEW_QUERYTABLE_MANAGEMENT_DEV_ADDR_TYPE > > > > #language en-US "Management Device - Address Type:" > > > > #string STR_SMBIOSVIEW_QUERYTABLE_MEM_CHANNEL_TYPE > > > > #language en-US "Memory Channel Type:" > > > > #string STR_SMBIOSVIEW_QUERYTABLE_BMC_INTERFACE_TYPE > > > > #language en-US "BMC Interface Type:" > > > > +#string STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE > > > > #language en-US "MC Host Interface Type:" > > > > #string STR_SMBIOSVIEW_QUERYTABLE_STRUCT_TYPE > > #language > > > > en-US "Structure Type:" > > > > #string STR_SMBIOSVIEW_SMBIOSVIEW_ONE_VAR_ARGV > > > > #language en-US "%s " > > > > #string STR_SMBIOSVIEW_SMBIOSVIEW_QUERY_STRUCT_COND > > > > #language en-US "Query Structure, conditions are:\r\n" > > > > -- > > > > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel