public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Thomas Huth <thuth@redhat.com>,
	"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH] OptionRomPkg: Remove superfluous return statement
Date: Thu, 26 Jan 2017 02:41:44 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B88BC05@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1485338519-29861-1-git-send-email-thuth@redhat.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Thomas Huth [mailto:thuth@redhat.com]
> Sent: Wednesday, January 25, 2017 6:02 PM
> To: edk2-devel@ml01.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] OptionRomPkg: Remove superfluous return statement
> 
> If the code eventually returns "Status" anyway, it does not make sense to
> explicitly return "Status" in case of an error, too.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c
> b/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c
> index c03606b..1eceb23 100644
> --- a/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c
> +++ b/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c
> @@ -2404,9 +2404,6 @@ SetAttributes (
>               DataBits,
>               StopBits
>               );
> -  if (EFI_ERROR (Status)) {
> -    return Status;
> -  }
> 
>    return Status;
>  }
> --
> 1.8.3.1



      reply	other threads:[~2017-01-26  2:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 10:01 [PATCH] OptionRomPkg: Remove superfluous return statement Thomas Huth
2017-01-26  2:41 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B88BC05@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox