From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Thomas Palmer <thomas.palmer@hpe.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
Date: Fri, 3 Feb 2017 08:06:06 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B893036@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1485920100-33234-1-git-send-email-thomas.palmer@hpe.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Regards,
Ray
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Palmer
>Sent: Wednesday, February 1, 2017 11:35 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
>
>On GCC built UEFIs, the "cp" command fails with "The source and
>destination are the same".
>
>The root cause is that StrniCmp failed to detect a case-
>insensitive string difference due to the InternalCharToUpper function
>being improperly declared.
>
>Fix is to add missing EFIAPI token to match the original
>implementation.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
>---
> .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>index 7948e53cfc46..4dbff4de26f8 100644
>--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>@@ -21,6 +21,7 @@
>
> * functions are non-interactive only
>
>+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
>@@ -268,6 +269,7 @@ VerifyIntermediateDirectories (
> @return Char as an upper case character.
> **/
> CHAR16
>+EFIAPI
> InternalCharToUpper (
> IN CONST CHAR16 Char
> );
>--
>2.7.4
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-02-03 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 3:35 [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems Thomas Palmer
2017-02-03 8:06 ` Ni, Ruiyu [this message]
2017-02-03 17:45 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B893036@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox