From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 357E382095 for ; Fri, 3 Feb 2017 00:06:14 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 03 Feb 2017 00:06:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="60400481" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 03 Feb 2017 00:06:09 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 00:06:09 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 00:06:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 16:06:07 +0800 From: "Ni, Ruiyu" To: Thomas Palmer , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems Thread-Index: AQHSfDwzluEVU3tw4EW1wL8W0+vvS6FW8DqQ Date: Fri, 3 Feb 2017 08:06:06 +0000 Deferred-Delivery: Fri, 3 Feb 2017 08:06:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B893036@SHSMSX104.ccr.corp.intel.com> References: <1485920100-33234-1-git-send-email-thomas.palmer@hpe.com> In-Reply-To: <1485920100-33234-1-git-send-email-thomas.palmer@hpe.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjhjM2JjNzAtNTNmYy00ZjI2LWEzYmQtYTMzNTg0YWFhODMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJiYk02ZTZkUFN2a1ZFajNpcEpuWnI5VzMwS1NNMmNyMlNWWmI3MFRYbk5NPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 08:06:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tho= mas Palmer >Sent: Wednesday, February 1, 2017 11:35 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" = for GCC systems > >On GCC built UEFIs, the "cp" command fails with "The source and >destination are the same". > >The root cause is that StrniCmp failed to detect a case- >insensitive string difference due to the InternalCharToUpper function >being improperly declared. > >Fix is to add missing EFIAPI token to match the original >implementation. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Thomas Palmer >--- > .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c |= 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Co= mmandsLib.c >b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c >index 7948e53cfc46..4dbff4de26f8 100644 >--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsL= ib.c >+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsL= ib.c >@@ -21,6 +21,7 @@ > > * functions are non-interactive only > >+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> Copyright (c) 2014 Hewlett-Packard Development Company, L.P. > Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
> This program and the accompanying materials >@@ -268,6 +269,7 @@ VerifyIntermediateDirectories ( > @return Char as an upper case character. > **/ > CHAR16 >+EFIAPI > InternalCharToUpper ( > IN CONST CHAR16 Char > ); >-- >2.7.4 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel