From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0407182095 for ; Fri, 3 Feb 2017 00:28:40 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 03 Feb 2017 00:28:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="55003759" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 03 Feb 2017 00:28:40 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 00:28:40 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 00:28:39 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 16:28:33 +0800 From: "Ni, Ruiyu" To: Laszlo Ersek , "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Fan, Jeff" Thread-Topic: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros Thread-Index: AQHSfc8E1fN6RNEK20yxLsvlB/5R8aFWaROAgACH2DA= Date: Fri, 3 Feb 2017 08:28:33 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B893155@SHSMSX104.ccr.corp.intel.com> References: <20170126060927.352436-1-ruiyu.ni@intel.com> <20170126060927.352436-2-ruiyu.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6239@shsmsx102.ccr.corp.intel.com> <6c292d21-9327-33cd-62ff-5f5f63cd371d@redhat.com> In-Reply-To: <6c292d21-9327-33cd-62ff-5f5f63cd371d@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 08:28:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Sure I will make sure OVMF build is fine with this change. Liming, The three deprecated macros PCI_BAR_EVEN_ALIGN, PCI_BAR_SQUAD_ALIGN and PCI_BAR_DQUAD_ALIGN don't have replacement. If wrapping them with DISABLE_NEW_DEPRECATED_INTERFACES, MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe build will break. What's your opinion about this driver? Thanks/Ray > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Friday, February 3, 2017 4:13 PM > To: Gao, Liming ; Ni, Ruiyu ; > edk2-devel@lists.01.org > Cc: Fan, Jeff > Subject: Re: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec > IncompatiblePciDevice macros >=20 > On 02/03/17 04:38, Gao, Liming wrote: > > Ray: > > How about wrap them by macro > DISABLE_NEW_DEPRECATED_INTERFACES to avoid them be used any more? >=20 > OvmfPkg uses some of these macros, and also defines > DISABLE_NEW_DEPRECATED_INTERFACES. So if the above suggestion is > followed, then a conversion patch for OvmfPkg becomes necessary as first > step, to the new values. >=20 > Thanks > Laszlo >=20 > > > > Thanks > > Liming > >> -----Original Message----- > >> From: Ni, Ruiyu > >> Sent: Thursday, January 26, 2017 2:09 PM > >> To: edk2-devel@lists.01.org > >> Cc: Gao, Liming ; Fan, Jeff > >> > >> Subject: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec > >> IncompatiblePciDevice macros > >> > >> DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 > >> should be used to match any VendorId/DeviceId/RevisionId/ > >> SubsystemVendorId/SubsystemDeviceId. > >> > >> PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ > >> PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such > >> definitions. > >> > >> PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64) -1 should be > >> used to match all BARs. > >> > >> All of the above macros are marked as deprecated. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Ruiyu Ni > >> Cc: Liming Gao > >> Cc: Jeff Fan > >> --- > >> MdePkg/Include/IndustryStandard/Pci22.h | 16 ++++++++++------ > >> 1 file changed, 10 insertions(+), 6 deletions(-) > >> > >> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h > >> b/MdePkg/Include/IndustryStandard/Pci22.h > >> index 4cf8389..8f87b04 100644 > >> --- a/MdePkg/Include/IndustryStandard/Pci22.h > >> +++ b/MdePkg/Include/IndustryStandard/Pci22.h > >> @@ -780,14 +780,18 @@ typedef struct { > >> /// > >> } EFI_PCI_CAPABILITY_HOTPLUG; > >> > >> -#define DEVICE_ID_NOCARE 0xFFFF > >> +/// > >> +/// Below macros (till PCI_BAR_ALL) were used by > >> EfiIncompatiblePciDeviceSupport Protocol. > >> +/// Some of them don't match Spec or are not defined in Spec. Those > >> +are > >> marked as deprecated. > >> +/// > >> +#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't > >> match Spec. > >> > >> #define PCI_ACPI_UNUSED 0 > >> #define PCI_BAR_NOCHANGE 0 > >> -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL > >> -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL -#define > >> PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL -#define > >> PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL > >> +#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< > Deprecated. > >> Value isn't defined in Spec. > >> +#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< > Deprecated. > >> Value isn't defined in Spec. > >> +#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< > Deprecated. > >> Value isn't defined in Spec. > >> +#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< > Deprecated. > >> Value isn't defined in Spec. > >> > >> #define PCI_BAR_IDX0 0x00 > >> #define PCI_BAR_IDX1 0x01 > >> @@ -795,7 +799,7 @@ typedef struct { > >> #define PCI_BAR_IDX3 0x03 > >> #define PCI_BAR_IDX4 0x04 > >> #define PCI_BAR_IDX5 0x05 > >> -#define PCI_BAR_ALL 0xFF > >> +#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't ma= tch > Spec. > >> > >> /// > >> /// EFI PCI Option ROM definitions > >> -- > >> 2.9.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > >