From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EF8781F4C for ; Fri, 3 Feb 2017 01:03:37 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 03 Feb 2017 01:03:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208,217";a="220883705" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 03 Feb 2017 01:03:36 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 01:03:36 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Feb 2017 01:03:35 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 17:03:33 +0800 From: "Ni, Ruiyu" To: "Gao, Liming" , Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Fan, Jeff" Thread-Topic: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros Thread-Index: AQHSfc8E1fN6RNEK20yxLsvlB/5R8aFWaROAgACH2DD//36VgIAAjXww Date: Fri, 3 Feb 2017 09:03:32 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B893333@SHSMSX104.ccr.corp.intel.com> References: <20170126060927.352436-1-ruiyu.ni@intel.com> <20170126060927.352436-2-ruiyu.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6239@shsmsx102.ccr.corp.intel.com> <6c292d21-9327-33cd-62ff-5f5f63cd371d@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5B893155@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6412@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6412@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmE1ZWY1NmMtMjUyMS00NGZkLWEwNmEtNDFkMGE5MzVlYjZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InVDelZyMXd6Mkk3RGtCN1Rzc0hWT2VaTEI1UGk2ZktPc1J5ZjZ4YU95YWs9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:03:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable yes. That's a good idea to move the definitions to local. Regards, Ray From: Gao, Liming Sent: Friday, February 3, 2017 4:36 PM To: Ni, Ruiyu ; Laszlo Ersek ; edk2-= devel@lists.01.org Cc: Fan, Jeff Subject: RE: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec Incom= patiblePciDevice macros Ray: If they are not recommended to be used any longer, I suggest to update In= compatiblePciDeviceSupportDxe driver not use them. The driver can have its = incompatible definition. Thanks Liming >-----Original Message----- >From: Ni, Ruiyu >Sent: Friday, February 03, 2017 4:29 PM >To: Laszlo Ersek >; Gao, Limin= g >; >edk2-devel@lists.01.org > >Cc: Fan, Jeff > >Subject: RE: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec >IncompatiblePciDevice macros > >Laszlo, >Sure I will make sure OVMF build is fine with this change. > >Liming, >The three deprecated macros PCI_BAR_EVEN_ALIGN, >PCI_BAR_SQUAD_ALIGN and PCI_BAR_DQUAD_ALIGN don't have >replacement. >If wrapping them with DISABLE_NEW_DEPRECATED_INTERFACES, >MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe build will break. >What's your opinion about this driver? > > >Thanks/Ray > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, February 3, 2017 4:13 PM >> To: Gao, Liming >; Ni,= Ruiyu >; >> edk2-devel@lists.01.org > >> Cc: Fan, Jeff > >> Subject: Re: [edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec >> IncompatiblePciDevice macros >> >> On 02/03/17 04:38, Gao, Liming wrote: >> > Ray: >> > How about wrap them by macro >> DISABLE_NEW_DEPRECATED_INTERFACES to avoid them be used any more? >> >> OvmfPkg uses some of these macros, and also defines >> DISABLE_NEW_DEPRECATED_INTERFACES. So if the above suggestion is >> followed, then a conversion patch for OvmfPkg becomes necessary as first >> step, to the new values. >> >> Thanks >> Laszlo >> >> > >> > Thanks >> > Liming >> >> -----Original Message----- >> >> From: Ni, Ruiyu >> >> Sent: Thursday, January 26, 2017 2:09 PM >> >> To: edk2-devel@lists.01.org >> >> Cc: Gao, Liming >; = Fan, Jeff >> >> > >> >> Subject: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec >> >> IncompatiblePciDevice macros >> >> >> >> DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 >> >> should be used to match any VendorId/DeviceId/RevisionId/ >> >> SubsystemVendorId/SubsystemDeviceId. >> >> >> >> PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ >> >> PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such >> >> definitions. >> >> >> >> PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64) -1 should be >> >> used to match all BARs. >> >> >> >> All of the above macros are marked as deprecated. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> >> Signed-off-by: Ruiyu Ni > >> >> Cc: Liming Gao > >> >> Cc: Jeff Fan > >> >> --- >> >> MdePkg/Include/IndustryStandard/Pci22.h | 16 ++++++++++------ >> >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> >> >> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h >> >> b/MdePkg/Include/IndustryStandard/Pci22.h >> >> index 4cf8389..8f87b04 100644 >> >> --- a/MdePkg/Include/IndustryStandard/Pci22.h >> >> +++ b/MdePkg/Include/IndustryStandard/Pci22.h >> >> @@ -780,14 +780,18 @@ typedef struct { >> >> /// >> >> } EFI_PCI_CAPABILITY_HOTPLUG; >> >> >> >> -#define DEVICE_ID_NOCARE 0xFFFF >> >> +/// >> >> +/// Below macros (till PCI_BAR_ALL) were used by >> >> EfiIncompatiblePciDeviceSupport Protocol. >> >> +/// Some of them don't match Spec or are not defined in Spec. Those >> >> +are >> >> marked as deprecated. >> >> +/// >> >> +#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't >> >> match Spec. >> >> >> >> #define PCI_ACPI_UNUSED 0 >> >> #define PCI_BAR_NOCHANGE 0 >> >> -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL >> >> -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL -#define >> >> PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL -#define >> >> PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL >> >> +#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< >> Deprecated. >> >> Value isn't defined in Spec. >> >> +#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< >> Deprecated. >> >> Value isn't defined in Spec. >> >> +#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< >> Deprecated. >> >> Value isn't defined in Spec. >> >> +#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< >> Deprecated. >> >> Value isn't defined in Spec. >> >> >> >> #define PCI_BAR_IDX0 0x00 >> >> #define PCI_BAR_IDX1 0x01 >> >> @@ -795,7 +799,7 @@ typedef struct { >> >> #define PCI_BAR_IDX3 0x03 >> >> #define PCI_BAR_IDX4 0x04 >> >> #define PCI_BAR_IDX5 0x05 >> >> -#define PCI_BAR_ALL 0xFF >> >> +#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't m= atch >> Spec. >> >> >> >> /// >> >> /// EFI PCI Option ROM definitions >> >> -- >> >> 2.9.0.windows.1 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel >> >