From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82FA8820BA for ; Wed, 8 Feb 2017 18:10:51 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP; 08 Feb 2017 18:10:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,349,1484035200"; d="scan'208";a="56763563" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 08 Feb 2017 18:10:51 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Feb 2017 18:10:50 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 10:10:39 +0800 From: "Ni, Ruiyu" To: Laszlo Ersek , "edk2-devel@ml01.01.org" CC: "Fan, Jeff" , "Gao, Liming" Thread-Topic: [edk2] [PATCH v4 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros Thread-Index: AQHSge/JfYQhVYNHmkmc/I4FzmtJBqFeZrWAgAGH28A= Date: Thu, 9 Feb 2017 02:10:38 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B89B1BC@SHSMSX104.ccr.corp.intel.com> References: <20170208094258.59568-1-ruiyu.ni@intel.com> <20170208094258.59568-2-ruiyu.ni@intel.com> <0d5ee574-1d0a-fb68-0564-3910f024c6a0@redhat.com> In-Reply-To: <0d5ee574-1d0a-fb68-0564-3910f024c6a0@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 02:10:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The reason actually is simple: I remembered to change the commit message but forgot to change the code. I am using a Windows GUI tool (TortoiseGit) = to change the patch. I just re-sent the correct patch. Please help to review it. Thanks/Ray > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, February 8, 2017 6:45 PM > To: Ni, Ruiyu ; edk2-devel@ml01.01.org > Cc: Fan, Jeff ; Gao, Liming > Subject: Re: [edk2] [PATCH v4 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec > IncompatiblePciDevice macros >=20 > On 02/08/17 10:42, Ruiyu Ni wrote: > > DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 should > > be used to match any VendorId/DeviceId/RevisionId/ > > SubsystemVendorId/SubsystemDeviceId. > > > > PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ > > PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such > > definitions. > > > > PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64)-1 should be used > > to match all BARs. > > > > PCI_ACPI_UNUSED and PCI_BAR_NOCHANGE are defined as 0 which > compliant > > with Spec but the name is too general and causes confusing. > > IncompatiblePciDeviceSupport could directly use 0. > > > > All of the above macros are marked as deprecated. >=20 > I agree with the commit message update (thanks for that!), but > PCI_ACPI_UNUSED and PCI_BAR_NOCHANGE aren't actually moved into the > (!DISABLE_NEW_DEPRECATED_INTERFACES) section, apparently. >=20 > Did you perhaps forget "git add" before "git commit --amend"? That would > explain why the commit message was updated, but the patch wasn't. >=20 > Thanks > Laszlo >=20 > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ruiyu Ni > > Cc: Liming Gao > > Cc: Jeff Fan > > --- > > MdePkg/Include/IndustryStandard/Pci22.h | 24 +++++++++++++++++----- > -- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Pci22.h > > b/MdePkg/Include/IndustryStandard/Pci22.h > > index 4cf8389..5dec65d 100644 > > --- a/MdePkg/Include/IndustryStandard/Pci22.h > > +++ b/MdePkg/Include/IndustryStandard/Pci22.h > > @@ -7,7 +7,7 @@ > > PC Card Standard, 8.0 > > PCI Power Management Interface Specifiction, Revision 1.2 > > > > - Copyright (c) 2006 - 2016, Intel Corporation. All rights > > reserved.
> > + Copyright (c) 2006 - 2017, Intel Corporation. All rights > > + reserved.
> > Copyright (c) 2014 - 2015, Hewlett-Packard Development Company, > L.P.
> > This program and the accompanying materials > > are licensed and made available under the terms and conditions of th= e > BSD License > > @@ -780,14 +780,25 @@ typedef struct { > > /// > > } EFI_PCI_CAPABILITY_HOTPLUG; > > > > -#define DEVICE_ID_NOCARE 0xFFFF > > +/// > > +/// Below macros (till PCI_BAR_NOCHANGE) were used by > EfiIncompatiblePciDeviceSupport Protocol. > > +/// > > +#ifndef DISABLE_NEW_DEPRECATED_INTERFACES > > + > > +/// > > +/// [ATTENTION] These macros are deprecated because they don't match > Spec or not defined in Spec. > > +/// > > +#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Va= lue > doesn't match Spec. > > +#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. > Value isn't defined in Spec. > > +#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< > Deprecated. Value isn't defined in Spec. > > +#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< > Deprecated. Value isn't defined in Spec. > > +#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< > Deprecated. Value isn't defined in Spec. > > +#define PCI_BAR_ALL 0xFF ///< Deprecated. Va= lue doesn't > match Spec. > > + > > +#endif > > > > #define PCI_ACPI_UNUSED 0 > > #define PCI_BAR_NOCHANGE 0 > > -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL > > -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL -#define > > PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL -#define > PCI_BAR_DQUAD_ALIGN > > 0xFFFFFFFFFFFFFFFCULL > > > > #define PCI_BAR_IDX0 0x00 > > #define PCI_BAR_IDX1 0x01 > > @@ -795,7 +806,6 @@ typedef struct { > > #define PCI_BAR_IDX3 0x03 > > #define PCI_BAR_IDX4 0x04 > > #define PCI_BAR_IDX5 0x05 > > -#define PCI_BAR_ALL 0xFF > > > > /// > > /// EFI PCI Option ROM definitions > >