From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of GUID and Protocol
Date: Wed, 15 Feb 2017 09:00:13 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8A42AD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1487148007-6668-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, February 15, 2017 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of
> GUID and Protocol
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=316
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
> .../UefiBootManagerLib/UefiBootManagerLib.inf | 54 ++++++++++++-----
> -----
> 1 file changed, 29 insertions(+), 25 deletions(-)
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index bb7c00d..6442f22 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -5,7 +5,7 @@
> # manipulation, hotkey registration, UEFI boot, connect/disconnect, console
> # manipulation, driver health checking and etc.
> #
> -# Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.<BR>
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the
> BSD License
> @@ -71,17 +71,21 @@
> SortLib
>
> [Guids]
> - gEfiMemoryTypeInformationGuid ## CONSUMES ## GUID (The
> identifier of memory type information type in system table)
> - ## CONSUMES ## GUID HOB (The hob holding
> memory type information)
> - gEfiGlobalVariableGuid ## SOMETIMES_PRODUCES ##
> Variable:L"BootCurrent" (The boot option of current boot)
> - ## SOMETIMES_CONSUMES ## Variable:L"BootXX"
> (Boot option variable)
> - ## CONSUMES ## Variable:L"Timeout" (The
> time out value in second of showing progress bar)
> - ## SOMETIMES_CONSUMES ##
> Variable:L"BootOrder" (The boot option array)
> - ## SOMETIMES_CONSUMES ##
> Variable:L"DriverOrder" (The driver order list)
> - ## SOMETIMES_CONSUMES ## Variable:L"ConIn"
> (The device path of console in device)
> - ## SOMETIMES_CONSUMES ## Variable:L"ConOut"
> (The device path of console out device)
> - ## SOMETIMES_CONSUMES ## Variable:L"ErrOut"
> (The device path of error out device)
> - gEfiFileInfoGuid ## CONSUMES ## GUID
> + ## SOMETIMES_CONSUMES ## SystemTable (The identifier of memory
> type information type in system table)
> + ## SOMETIMES_CONSUMES ## HOB (The hob holding memory type
> information)
> + ## SOMETIMES_CONSUMES ## Variable:L"MemoryTypeInformation."
> + ## SOMETIMES_PRODUCES ## Variable:L"MemoryTypeInformation."
> + gEfiMemoryTypeInformationGuid
> +
> + ## SOMETIMES_PRODUCES ## Variable:L"BootCurrent" (The boot option
> of current boot)
> + ## SOMETIMES_CONSUMES ## Variable:L"BootXX" (Boot option variable)
> + ## SOMETIMES_CONSUMES ## Variable:L"BootOrder" (The boot option
> array)
> + ## SOMETIMES_CONSUMES ## Variable:L"DriverOrder" (The driver order
> list)
> + ## SOMETIMES_CONSUMES ## Variable:L"ConIn" (The device path of
> console in device)
> + ## SOMETIMES_CONSUMES ## Variable:L"ConOut" (The device path of
> console out device)
> + ## SOMETIMES_CONSUMES ## Variable:L"ErrOut" (The device path of
> error out device)
> + gEfiGlobalVariableGuid
> +
> gPerformanceProtocolGuid ## SOMETIMES_CONSUMES ##
> Variable:L"PerfDataMemAddr" (The ACPI address of performance data)
> gEdkiiStatusCodeDataTypeVariableGuid ## SOMETIMES_CONSUMES
> ## GUID
> gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_CONSUMES ##
> GUID
> @@ -90,26 +94,26 @@
>
> [Protocols]
> gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
> - gEfiSimpleFileSystemProtocolGuid ## CONSUMES
> - gEfiLoadFileProtocolGuid ## CONSUMES
> - gEfiSimpleTextOutProtocolGuid ## CONSUMES
> - gEfiPciIoProtocolGuid ## CONSUMES
> + gEfiSimpleFileSystemProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiLoadFileProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiSimpleTextOutProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiPciIoProtocolGuid ## SOMETIMES_CONSUMES
> gEfiLoadedImageProtocolGuid ## CONSUMES
> - gEfiSimpleNetworkProtocolGuid ## CONSUMES
> - gEfiSimpleTextInProtocolGuid ## CONSUMES
> - gEfiBlockIoProtocolGuid ## CONSUMES
> - gEfiFirmwareVolume2ProtocolGuid ## CONSUMES
> - gEfiDevicePathProtocolGuid ## CONSUMES
> - gEfiBootLogoProtocolGuid ## CONSUMES
> - gEfiSimpleTextInputExProtocolGuid ## CONSUMES
> - gEdkiiVariableLockProtocolGuid ## CONSUMES
> + gEfiSimpleNetworkProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiSimpleTextInProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiBlockIoProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiFirmwareVolume2ProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiDevicePathProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiBootLogoProtocolGuid ## SOMETIMES_CONSUMES
> + gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES
> + gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES
> gEfiGraphicsOutputProtocolGuid ## SOMETIMES_CONSUMES
> gEfiUsbIoProtocolGuid ## SOMETIMES_CONSUMES
> gEfiDiskInfoProtocolGuid ## SOMETIMES_CONSUMES
> gEfiDriverHealthProtocolGuid ## SOMETIMES_CONSUMES
> gEfiFormBrowser2ProtocolGuid ## SOMETIMES_CONSUMES
> gEfiRamDiskProtocolGuid ## SOMETIMES_CONSUMES
> - gEfiDeferredImageLoadProtocolGuid ## CONSUMES
> + gEfiDeferredImageLoadProtocolGuid ## SOMETIMES_CONSUMES
>
> [Pcd]
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC
> hange ## SOMETIMES_CONSUMES
> --
> 2.8.0.windows.1
prev parent reply other threads:[~2017-02-15 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 8:40 [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of GUID and Protocol Liming Gao
2017-02-15 9:00 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B8A42AD@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox