From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D133881F40 for ; Wed, 15 Feb 2017 01:00:33 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2017 01:00:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,165,1484035200"; d="scan'208";a="65379264" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 15 Feb 2017 01:00:18 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Feb 2017 01:00:18 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Feb 2017 01:00:17 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 15 Feb 2017 17:00:13 +0800 From: "Ni, Ruiyu" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of GUID and Protocol Thread-Index: AQHSh2cql+WgpgMVUEaCWo0QBzmfm6FpxLSA Date: Wed, 15 Feb 2017 09:00:13 +0000 Deferred-Delivery: Wed, 15 Feb 2017 09:00:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8A42AD@SHSMSX104.ccr.corp.intel.com> References: <1487148007-6668-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1487148007-6668-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of GUID and Protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 09:00:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, February 15, 2017 4:40 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch] MdeModulePkg UefiBootManagerLib: Correct usages of > GUID and Protocol >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D316 >=20 > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > .../UefiBootManagerLib/UefiBootManagerLib.inf | 54 ++++++++++++----= - > ----- > 1 file changed, 29 insertions(+), 25 deletions(-) >=20 > diff --git > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > index bb7c00d..6442f22 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > +++ > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -5,7 +5,7 @@ > # manipulation, hotkey registration, UEFI boot, connect/disconnect, con= sole > # manipulation, driver health checking and etc. > # > -# Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved. > # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the > BSD License > @@ -71,17 +71,21 @@ > SortLib >=20 > [Guids] > - gEfiMemoryTypeInformationGuid ## CONSUMES ## GUID (The > identifier of memory type information type in system table) > - ## CONSUMES ## GUID HOB = (The hob holding > memory type information) > - gEfiGlobalVariableGuid ## SOMETIMES_PRODUCES ## > Variable:L"BootCurrent" (The boot option of current boot) > - ## SOMETIMES_CONSUMES ##= Variable:L"BootXX" > (Boot option variable) > - ## CONSUMES ##= Variable:L"Timeout" (The > time out value in second of showing progress bar) > - ## SOMETIMES_CONSUMES ## > Variable:L"BootOrder" (The boot option array) > - ## SOMETIMES_CONSUMES ## > Variable:L"DriverOrder" (The driver order list) > - ## SOMETIMES_CONSUMES ##= Variable:L"ConIn" > (The device path of console in device) > - ## SOMETIMES_CONSUMES ##= Variable:L"ConOut" > (The device path of console out device) > - ## SOMETIMES_CONSUMES ##= Variable:L"ErrOut" > (The device path of error out device) > - gEfiFileInfoGuid ## CONSUMES ## GUID > + ## SOMETIMES_CONSUMES ## SystemTable (The identifier of memory > type information type in system table) > + ## SOMETIMES_CONSUMES ## HOB (The hob holding memory type > information) > + ## SOMETIMES_CONSUMES ## Variable:L"MemoryTypeInformation." > + ## SOMETIMES_PRODUCES ## Variable:L"MemoryTypeInformation." > + gEfiMemoryTypeInformationGuid > + > + ## SOMETIMES_PRODUCES ## Variable:L"BootCurrent" (The boot option > of current boot) > + ## SOMETIMES_CONSUMES ## Variable:L"BootXX" (Boot option variable) > + ## SOMETIMES_CONSUMES ## Variable:L"BootOrder" (The boot option > array) > + ## SOMETIMES_CONSUMES ## Variable:L"DriverOrder" (The driver order > list) > + ## SOMETIMES_CONSUMES ## Variable:L"ConIn" (The device path of > console in device) > + ## SOMETIMES_CONSUMES ## Variable:L"ConOut" (The device path of > console out device) > + ## SOMETIMES_CONSUMES ## Variable:L"ErrOut" (The device path of > error out device) > + gEfiGlobalVariableGuid > + > gPerformanceProtocolGuid ## SOMETIMES_CONSUMES ## > Variable:L"PerfDataMemAddr" (The ACPI address of performance data) > gEdkiiStatusCodeDataTypeVariableGuid ## SOMETIMES_CONSUMES > ## GUID > gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_CONSUMES ## > GUID > @@ -90,26 +94,26 @@ >=20 > [Protocols] > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES > - gEfiSimpleFileSystemProtocolGuid ## CONSUMES > - gEfiLoadFileProtocolGuid ## CONSUMES > - gEfiSimpleTextOutProtocolGuid ## CONSUMES > - gEfiPciIoProtocolGuid ## CONSUMES > + gEfiSimpleFileSystemProtocolGuid ## SOMETIMES_CONSUMES > + gEfiLoadFileProtocolGuid ## SOMETIMES_CONSUMES > + gEfiSimpleTextOutProtocolGuid ## SOMETIMES_CONSUMES > + gEfiPciIoProtocolGuid ## SOMETIMES_CONSUMES > gEfiLoadedImageProtocolGuid ## CONSUMES > - gEfiSimpleNetworkProtocolGuid ## CONSUMES > - gEfiSimpleTextInProtocolGuid ## CONSUMES > - gEfiBlockIoProtocolGuid ## CONSUMES > - gEfiFirmwareVolume2ProtocolGuid ## CONSUMES > - gEfiDevicePathProtocolGuid ## CONSUMES > - gEfiBootLogoProtocolGuid ## CONSUMES > - gEfiSimpleTextInputExProtocolGuid ## CONSUMES > - gEdkiiVariableLockProtocolGuid ## CONSUMES > + gEfiSimpleNetworkProtocolGuid ## SOMETIMES_CONSUMES > + gEfiSimpleTextInProtocolGuid ## SOMETIMES_CONSUMES > + gEfiBlockIoProtocolGuid ## SOMETIMES_CONSUMES > + gEfiFirmwareVolume2ProtocolGuid ## SOMETIMES_CONSUMES > + gEfiDevicePathProtocolGuid ## SOMETIMES_CONSUMES > + gEfiBootLogoProtocolGuid ## SOMETIMES_CONSUMES > + gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > + gEdkiiVariableLockProtocolGuid ## SOMETIMES_CONSUMES > gEfiGraphicsOutputProtocolGuid ## SOMETIMES_CONSUMES > gEfiUsbIoProtocolGuid ## SOMETIMES_CONSUMES > gEfiDiskInfoProtocolGuid ## SOMETIMES_CONSUMES > gEfiDriverHealthProtocolGuid ## SOMETIMES_CONSUMES > gEfiFormBrowser2ProtocolGuid ## SOMETIMES_CONSUMES > gEfiRamDiskProtocolGuid ## SOMETIMES_CONSUMES > - gEfiDeferredImageLoadProtocolGuid ## CONSUMES > + gEfiDeferredImageLoadProtocolGuid ## SOMETIMES_CONSUMES >=20 > [Pcd] >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC > hange ## SOMETIMES_CONSUMES > -- > 2.8.0.windows.1