public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH 3/7] Nt32Pkg: Replace [Ascii|Unicode]ValueToString
Date: Wed, 22 Feb 2017 01:57:38 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8AA9BC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1487676934-12984-4-git-send-email-hao.a.wu@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hao
> Wu
> Sent: Tuesday, February 21, 2017 7:36 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH 3/7] Nt32Pkg: Replace [Ascii|Unicode]ValueToString
> 
> It is the follow up of commits 51f0ceb..9e32e97 to replace
> AsciiValueToString/UnicodeValueToString with
> AsciiValueToStringS/UnicodeValueToStringS.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Nt32Pkg/Library/PlatformBootManagerLib/MemoryTest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/MemoryTest.c
> b/Nt32Pkg/Library/PlatformBootManagerLib/MemoryTest.c
> index 93ecc7d..53e9ff4 100644
> --- a/Nt32Pkg/Library/PlatformBootManagerLib/MemoryTest.c
> +++ b/Nt32Pkg/Library/PlatformBootManagerLib/MemoryTest.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Perform the platform memory test
> 
> -Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials  are licensed and made available
> under the terms and conditions of the BSD License  which accompanies this
> distribution.  The full text of the license may be found at @@ -155,7 +155,7 @@
> PlatformBootManagerMemoryTest (
>                                TempData
>                                );
>        if (TestPercent != PreviousValue) {
> -        UnicodeValueToString (StrPercent, 0, TestPercent, 0);
> +        UnicodeValueToStringS (StrPercent, sizeof (StrPercent), 0,
> + TestPercent, 0);
>          TmpStr = HiiGetString (gStringPackHandle, STRING_TOKEN
> (STR_MEMORY_TEST_PERCENT), NULL);
>          if (TmpStr != NULL) {
>            //
> @@ -223,7 +223,7 @@ PlatformBootManagerMemoryTest (
> 
>  Done:
>    if (!FeaturePcdGet(PcdBootlogoOnlyEnable)) {
> -    UnicodeValueToString (StrTotalMemory, COMMA_TYPE, TotalMemorySize,
> 0);
> +    UnicodeValueToStringS (StrTotalMemory, StrTotalMemorySize,
> + COMMA_TYPE, TotalMemorySize, 0);
>      if (StrTotalMemory[0] == L',') {
>        StrTotalMemory++;
>        StrTotalMemorySize -= sizeof (CHAR16);
> --
> 1.9.5.msysgit.0
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-02-22  1:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 11:35 [PATCH 0/7] Mark [Ascii|Unicode]ValueToString as deprecated Hao Wu
2017-02-21 11:35 ` [PATCH 1/7] IntelFrameworkModulePkg: Replace [Ascii|Unicode]ValueToString Hao Wu
2017-02-27  7:36   ` Fan, Jeff
2017-02-21 11:35 ` [PATCH 2/7] MdeModulePkg: " Hao Wu
2017-02-28  8:13   ` Zeng, Star
2017-02-21 11:35 ` [PATCH 3/7] Nt32Pkg: " Hao Wu
2017-02-22  1:57   ` Ni, Ruiyu [this message]
2017-02-21 11:35 ` [PATCH 4/7] SignedCapsulePkg: " Hao Wu
2017-02-27  1:09   ` Yao, Jiewen
2017-02-21 11:35 ` [PATCH 5/7] MdeModulePkg/PrintDxe: Handle the deprecation of [A|U]ValueToString Hao Wu
2017-02-21 11:35 ` [PATCH 6/7] MdeModulePkg/PrintLib: Add deprecated flag for APIs [A|U]ValueToString Hao Wu
2017-02-21 11:35 ` [PATCH 7/7] MdePkg/BasePrintLib: " Hao Wu
2017-02-23  1:50 ` [PATCH 0/7] Mark [Ascii|Unicode]ValueToString as deprecated Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B8AA9BC@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox