From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B0DC821BB for ; Sun, 26 Feb 2017 18:37:34 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 26 Feb 2017 18:37:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,212,1484035200"; d="scan'208";a="229982007" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 26 Feb 2017 18:37:33 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 26 Feb 2017 18:37:33 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.59]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Mon, 27 Feb 2017 10:37:30 +0800 From: "Ni, Ruiyu" To: Laszlo Ersek , edk2-devel-01 CC: Tomas Hoger Thread-Topic: [edk2] [PATCH v2 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE Thread-Index: AQHSjo1w7VoUGvFad02Ntc0UPCpw5aF8J6Bg Date: Mon, 27 Feb 2017 02:37:29 +0000 Deferred-Delivery: Mon, 27 Feb 2017 02:37:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8B4096@SHSMSX104.ccr.corp.intel.com> References: <20170224110132.19374-1-lersek@redhat.com> <20170224110132.19374-5-lersek@redhat.com> In-Reply-To: <20170224110132.19374-5-lersek@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 02:37:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Friday, February 24, 2017 7:02 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu ; Tomas Hoger > Subject: [edk2] [PATCH v2 4/5] Nt32Pkg: exclude libssl functionality from > OpensslLib if TLS_ENABLE=3DFALSE >=20 > Ease security analysis by excluding libssl functionality from the Openssl= Lib > instance we use with TLS_ENABLE=3DFALSE. >=20 > Cc: Ruiyu Ni > Cc: Tomas Hoger > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > v2: > - fix typo "analsysis" in commit message > - resolve OpensslLib to OpensslLibCrypto.inf rather than to > OpensslLibNoSsl.inf in Nt32Pkg.dsc >=20 > v1: > - I can't build-test this. >=20 > Nt32Pkg/Nt32Pkg.dsc | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index > 47e37ecae134..499b1fe8abe0 100644 > --- a/Nt32Pkg/Nt32Pkg.dsc > +++ b/Nt32Pkg/Nt32Pkg.dsc > @@ -159,7 +159,11 @@ [LibraryClasses] >=20 > CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibN > ull/CpuExceptionHandlerLibNull.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > +!if $(TLS_ENABLE) =3D=3D TRUE > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > +!else > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +!endif >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE >=20 > PlatformSecureLib|Nt32Pkg/Library/PlatformSecureLib/PlatformSecureLib.in > f > -- > 2.9.3 >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel