public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Chen, Chen A" <chen.a.chen@intel.com>
Subject: Re: [patch 2/2] ShellPkg/Shell: Make comments align with the function
Date: Tue, 28 Mar 2017 02:16:50 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B8ED0ED@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1490662895-69668-2-git-send-email-dandan.bi@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, March 28, 2017 9:02 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch 2/2] ShellPkg/Shell: Make comments align with the function
> 
> Cc: Chen A Chen <chen.a.chen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Application/Shell/Shell.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index dfcbfb8..5a941aa 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -1134,12 +1134,12 @@ ProcessCommandLine(
>  /**
>    Function try to find location of the Startup.nsh file.
> 
>    The buffer is callee allocated and should be freed by the caller.
> 
> -  @param    ImagePath             The path to the image for shell.  first place to
> look for the startup script
> -  @param    FilePath              The path to the file for shell.  second place to look
> for the startup script.
> +  @param    ImageDevicePath       The path to the image for shell.  first place
> to look for the startup script
> +  @param    FileDevicePath        The path to the file for shell.  second place to
> look for the startup script.
> 
>    @retval   NULL                  No Startup.nsh file was found.
>    @return   !=NULL                Pointer to NULL-terminated path.
>  **/
>  CHAR16 *
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2017-03-28  2:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  1:01 [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue Dandan Bi
2017-03-28  1:01 ` [patch 2/2] ShellPkg/Shell: Make comments align with the function Dandan Bi
2017-03-28  2:16   ` Ni, Ruiyu [this message]
2017-03-28  6:43 ` [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue Tian, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B8ED0ED@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox