public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Fan, Jeff" <jeff.fan@intel.com>
Subject: Re: [patch] UefiCpuPkg/MtrrLib:Fix VS2012 build failure
Date: Wed, 5 Apr 2017 01:12:37 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B913E21@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1491354393-115588-1-git-send-email-dandan.bi@intel.com>

Dandan,
Thank you! I thought I fixed all the build failures.

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>


Regards,
Ray

>-----Original Message-----
>From: Bi, Dandan
>Sent: Wednesday, April 5, 2017 9:07 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Fan, Jeff <jeff.fan@intel.com>
>Subject: [patch] UefiCpuPkg/MtrrLib:Fix VS2012 build failure
>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Jeff Fan <jeff.fan@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
>index 8e84272..c38191a 100644
>--- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
>+++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
>@@ -700,10 +700,11 @@ MtrrLibGetPositiveMtrrNumber (
>   UINT64         SubLength;
>   UINT32         MtrrNumber;
>   BOOLEAN        UseLeastAlignment;
>
>   UseLeastAlignment = TRUE;
>+  SubLength = 0;
>
>   //
>   // Calculate the alignment of the base address.
>   //
>   for (MtrrNumber = 0; Length != 0; MtrrNumber++) {
>@@ -852,10 +853,11 @@ MtrrLibGetMtrrNumber (
>   UINT32  Index;
>
>   *SubLeft = 0;
>   *SubRight = 0;
>   LeastSubtractiveMtrrNumber = 0;
>+  BaseAlignment = 0;
>
>   //
>   // Get the optimal left subtraction solution.
>   //
>   if (BaseAddress != 0) {
>@@ -1625,10 +1627,12 @@ MtrrLibSetMemoryAttributeInVariableMtrr (
>   UINT32                    MtrrNumber;
>   UINT32                    SubtractiveLeft;
>   UINT32                    SubtractiveRight;
>   BOOLEAN                   UseLeastAlignment;
>
>+  Alignment = 0;
>+
>   MtrrNumber = MtrrLibGetMtrrNumber (Ranges, RangeCount, VariableMtrr, *VariableMtrrCount,
>                                      BaseAddress, Length, Type, Alignment0, &SubtractiveLeft, &SubtractiveRight);
>
>   if (MtrrNumber + *VariableMtrrCount > VariableMtrrCapacity) {
>     return RETURN_OUT_OF_RESOURCES;
>--
>1.9.5.msysgit.1



           reply	other threads:[~2017-04-05  1:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1491354393-115588-1-git-send-email-dandan.bi@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B913E21@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox