From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wang, Fan" <fan.wang@intel.com>, "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH] MdeModulePKg/BDS: Build meaningful description for Wi-Fi boot option
Date: Tue, 25 Apr 2017 05:17:53 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9392D5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20170420032321.61692-1-ruiyu.ni@intel.com>
Fan, Jiaxin,
Any comments?
Thanks/Ray
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, April 20, 2017 11:23 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.wang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH] MdeModulePKg/BDS: Build meaningful description
> for Wi-Fi boot option
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Fan Wang <fan.wang@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
> .../Library/UefiBootManagerLib/BmBootDescription.c | 28
> ++++++++++++++++++----
> 1 file changed, 23 insertions(+), 5 deletions(-)
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index 501a0cc255..6e69a1540a 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -382,13 +382,13 @@ BmGetNetworkDescription (
>
> //
> // The PXE device path is like:
> - // ....../Mac(...)[/Vlan(...)]
> - // ....../Mac(...)[/Vlan(...)]/IPv4(...)
> - // ....../Mac(...)[/Vlan(...)]/IPv6(...)
> + // ....../Mac(...)[/Vlan(...)][/Wi-Fi(...)]
> + // ....../Mac(...)[/Vlan(...)][/Wi-Fi(...)]/IPv4(...)
> + // ....../Mac(...)[/Vlan(...)][/Wi-Fi(...)]/IPv6(...)
> //
> // The HTTP device path is like:
> - // ....../Mac(...)[/Vlan(...)]/IPv4(...)/Uri(...)
> - // ....../Mac(...)[/Vlan(...)]/IPv6(...)/Uri(...)
> + // ....../Mac(...)[/Vlan(...)][/Wi-Fi(...)]/IPv4(...)/Uri(...)
> + // ....../Mac(...)[/Vlan(...)][/Wi-Fi(...)]/IPv6(...)/Uri(...)
> //
> while (!IsDevicePathEnd (DevicePath) &&
> ((DevicePathType (DevicePath) != MESSAGING_DEVICE_PATH) || @@ -
> 404,6 +404,9 @@ BmGetNetworkDescription (
> Mac = (MAC_ADDR_DEVICE_PATH *) DevicePath;
> DevicePath = NextDevicePathNode (DevicePath);
>
> + //
> + // Locate the optional Vlan node
> + //
> if ((DevicePathType (DevicePath) == MESSAGING_DEVICE_PATH) &&
> (DevicePathSubType (DevicePath) == MSG_VLAN_DP)
> ) {
> @@ -413,6 +416,18 @@ BmGetNetworkDescription (
> Vlan = NULL;
> }
>
> + //
> + // Skip the optional Wi-Fi node
> + //
> + if ((DevicePathType (DevicePath) == MESSAGING_DEVICE_PATH) &&
> + (DevicePathSubType (DevicePath) == MSG_WIFI_DP)
> + ) {
> + DevicePath = NextDevicePathNode (DevicePath); }
> +
> + //
> + // Locate the IP node
> + //
> if ((DevicePathType (DevicePath) == MESSAGING_DEVICE_PATH) &&
> ((DevicePathSubType (DevicePath) == MSG_IPv4_DP) ||
> (DevicePathSubType (DevicePath) == MSG_IPv6_DP)) @@ -423,6 +438,9
> @@ BmGetNetworkDescription (
> Ip = NULL;
> }
>
> + //
> + // Locate the URI node
> + //
> if ((DevicePathType (DevicePath) == MESSAGING_DEVICE_PATH) &&
> (DevicePathSubType (DevicePath) == MSG_URI_DP)
> ) {
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-04-25 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 3:23 [PATCH] MdeModulePKg/BDS: Build meaningful description for Wi-Fi boot option Ruiyu Ni
2017-04-25 5:17 ` Ni, Ruiyu [this message]
2017-04-25 8:05 ` Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B9392D5@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox