public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [patch 6/8] MdePkg: update comments in ResetSystem() according to UEFI2.7
Date: Mon, 19 Jun 2017 02:31:30 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B99BD1C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1497835292-34476-7-git-send-email-dandan.bi@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, June 19, 2017 9:22 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch 6/8] MdePkg: update comments in ResetSystem() according
> to UEFI2.7
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdePkg/Include/Library/UefiRuntimeLib.h | 7 +++----
>  MdePkg/Include/Uefi/UefiSpec.h          | 3 +++
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/UefiRuntimeLib.h
> b/MdePkg/Include/Library/UefiRuntimeLib.h
> index 99ca824..0bca416 100644
> --- a/MdePkg/Include/Library/UefiRuntimeLib.h
> +++ b/MdePkg/Include/Library/UefiRuntimeLib.h
> @@ -1,10 +1,10 @@
>  /** @file
>    Provides library functions for each of the UEFI Runtime Services.
>    Only available to DXE and UEFI module types.
> 
> -Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials are licensed and made
> available under  the terms and conditions of the BSD License that
> accompanies this distribution.
>  The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php.
> 
> @@ -327,13 +327,12 @@ EfiGetNextHighMonotonicCount (
>    @param  DataSizeThe size, in bytes, of ResetData.
>    @param  ResetData   For a ResetType of EfiResetCold, EfiResetWarm, or
> EfiResetShutdown the data buffer starts with a
>                        Null-terminated Unicode string, optionally followed by additional
> binary data. The string is a
>                        description that the caller may use to further indicate the reason
> for the system reset. ResetData
>                        is only valid if ResetStatus is something other then EFI_SUCCESS.
> This pointer must be a physical
> -                      address. For a ResetType of EfiRestUpdate the data buffer also
> starts with a Null-terminated string
> -                      that is followed by a physical VOID * to an EFI_CAPSULE_HEADER.
> -
> +                      address. For a ResetType of EfiResetPlatformSpecific the data
> buffer also starts with a Null-terminated
> +                      string that is followed by an EFI_GUID that describes the specific
> type of reset to perform.
>  **/
>  VOID
>  EFIAPI
>  EfiResetSystem (
>    IN EFI_RESET_TYPE               ResetType,
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> b/MdePkg/Include/Uefi/UefiSpec.h index 5774470..58acca2 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -1018,10 +1018,13 @@ EFI_STATUS
>                                  The string is a description that the caller may use to further
>                                  indicate the reason for the system reset. ResetData is only
>                                  valid if ResetStatus is something other than EFI_SUCCESS
>                                  unless the ResetType is EfiResetPlatformSpecific
>                                  where a minimum amount of ResetData is always required.
> +                                For a ResetType of EfiResetPlatformSpecific the data buffer
> +                                also starts with a Null-terminated string that is followed
> +                                by an EFI_GUID that describes the specific type of reset to
> perform.
>  **/
>  typedef
>  VOID
>  (EFIAPI *EFI_RESET_SYSTEM)(
>    IN EFI_RESET_TYPE           ResetType,
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2017-06-19  2:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  1:21 [patch 0/8] Update function comments according to UEFI2.7 spec Dandan Bi
2017-06-19  1:21 ` [patch 1/8] MdePkg/SimpleTextInEx: Update comments according to UEFI 2.7 spec Dandan Bi
2017-06-19  2:31   ` Ni, Ruiyu
2017-06-19  2:39   ` Zeng, Star
2017-06-19  1:21 ` [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx Dandan Bi
2017-06-19  2:31   ` Ni, Ruiyu
2017-06-19  2:40   ` Zeng, Star
2017-06-19  1:21 ` [patch 3/8] MdeModulePkg: Update comments in SimpleTextInEx according to UEFI 2.7 Dandan Bi
2017-06-19  2:31   ` Ni, Ruiyu
2017-06-19  2:41   ` Zeng, Star
2017-06-19  2:57     ` Bi, Dandan
2017-06-19  1:21 ` [patch 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments Dandan Bi
2017-06-19  2:31   ` Ni, Ruiyu
2017-06-19  1:21 ` [patch 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR according to UEFI2.7 Dandan Bi
2017-06-19  2:43   ` Zeng, Star
2017-06-19  1:21 ` [patch 6/8] MdePkg: update comments in ResetSystem() " Dandan Bi
2017-06-19  2:31   ` Ni, Ruiyu [this message]
2017-06-19  1:21 ` [patch 7/8] MdePkg: Clean ACPI 2.0 characters in UEFI spec Dandan Bi
2017-06-19  2:55   ` Zeng, Star
2017-06-19  1:21 ` [patch 8/8] MdeModulePkg: " Dandan Bi
2017-06-19  2:57   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B99BD1C@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox