From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BCF5521C8F615 for ; Sun, 18 Jun 2017 19:30:12 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 18 Jun 2017 19:31:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="275821442" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 18 Jun 2017 19:31:33 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:31:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:31:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:31:30 +0800 From: "Ni, Ruiyu" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zeng, Star" Thread-Topic: [patch 1/8] MdePkg/SimpleTextInEx: Update comments according to UEFI 2.7 spec Thread-Index: AQHS6Jpu49/95NZawEeMMr33eErmIqIrdt5Q Date: Mon, 19 Jun 2017 02:31:30 +0000 Deferred-Delivery: Mon, 19 Jun 2017 02:31:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B99BD2B@SHSMSX104.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497835292-34476-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 1/8] MdePkg/SimpleTextInEx: Update comments according to UEFI 2.7 spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:30:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 19, 2017 9:21 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Zeng, Star ; > Ni, Ruiyu > Subject: [patch 1/8] MdePkg/SimpleTextInEx: Update comments according > to UEFI 2.7 spec >=20 > Cc: Liming Gao > Cc: Star Zeng > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdePkg/Include/Protocol/SimpleTextInEx.h | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/SimpleTextInEx.h > b/MdePkg/Include/Protocol/SimpleTextInEx.h > index 436ff37..89f638a 100644 > --- a/MdePkg/Include/Protocol/SimpleTextInEx.h > +++ b/MdePkg/Include/Protocol/SimpleTextInEx.h > @@ -3,11 +3,11 @@ >=20 > This protocol defines an extension to the > EFI_SIMPLE_TEXT_INPUT_PROTOCOL > which exposes much more state and modifier information from the input > device, > also allows one to register a notification for a particular keystroke. >=20 > - Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > http://opensource.org/licenses/bsd-license.php >=20 > @@ -249,22 +249,23 @@ EFI_STATUS >=20 > @param This A pointer to the > EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL instance. >=20 > @param KeyData A pointer to a buffer that is filled i= n with > the keystroke information for the key = that was > - pressed. > + pressed.If KeyData.Key, KeyData.KeySta= te.KeyToggleState > + and KeyData.KeyState.KeyShiftState are= 0, then any > incomplete > + keystroke will trigger a notification = of the > KeyNotificationFunction. >=20 > - @param KeyNotificationFunction Points to the function to be > - called when the key sequence > - is typed specified by KeyData. > + @param KeyNotificationFunction Points to the function to be called wh= en > the key sequence > + is typed specified by KeyData.This not= ification function > + should be called at <=3DTPL_CALLBACK. >=20 >=20 > @param NotifyHandle Points to the unique handle assigned t= o > the registered notification. >=20 > - @retval EFI_SUCCESS The device state was set > - appropriately. > + @retval EFI_SUCCESS Key notify was registered successfully. >=20 > @retval EFI_OUT_OF_RESOURCES Unable to allocate necessary > data structures. >=20 > **/ > @@ -284,11 +285,11 @@ EFI_STATUS > @param This A pointer to the > EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL instance. >=20 > @param NotificationHandle The handle of the notification > function being unregistered. >=20 > - @retval EFI_SUCCESS The device state was set appropriately. > + @retval EFI_SUCCESS Key notify was unregistered successfully= . >=20 > @retval EFI_INVALID_PARAMETER The NotificationHandle is > invalid. >=20 > **/ > -- > 1.9.5.msysgit.1