From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0205621A07A94 for ; Sun, 18 Jun 2017 19:30:12 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2017 19:31:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="115964563" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 18 Jun 2017 19:31:33 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:31:33 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:31:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:31:31 +0800 From: "Ni, Ruiyu" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Fan, Jeff" Thread-Topic: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx Thread-Index: AQHS6JpurBcxwrmGsE6jAtEkdYvuxaIrduBA Date: Mon, 19 Jun 2017 02:31:30 +0000 Deferred-Delivery: Mon, 19 Jun 2017 02:31:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B99BD30@SHSMSX104.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-3-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497835292-34476-3-git-send-email-dandan.bi@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:30:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Bi, Dandan > Sent: Monday, June 19, 2017 9:21 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Ni, Ruiyu ; Fan= , > Jeff > Subject: [patch 2/8] IntelFrameworkModulePkg: Update comments in > SimpleTextInEx >=20 > Update comments in SimpleTextInEx according to UEFI 2.7. >=20 > Cc: Star Zeng > Cc: Ruiyu Ni > Cc: Jeff Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 10 +++++++--- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 10 +++++++--- > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 15 +++++++++-= ---- > - > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 16 ++++++++++= --- > --- > 4 files changed, 33 insertions(+), 18 deletions(-) >=20 > diff --git > a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c > b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c > index 5825a04..12ee529 100644 > --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c > +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c > @@ -1,10 +1,10 @@ > /** @file > Routines implements SIMPLE_TEXT_IN protocol's interfaces based on 8042 > interfaces > provided by Ps2KbdCtrller.c. >=20 > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be found= at > http://opensource.org/licenses/bsd-license.php >=20 > @@ -531,13 +531,17 @@ Exit: > /** > Register a notification function for a particular keystroke for the = input > device. >=20 > @param This Protocol instance pointer. > @param KeyData A pointer to a buffer that is fill= ed in with the > keystroke > - information data for the key that = was pressed. > + information data for the key that = was pressed.If > KeyData.Key, > + KeyData.KeyState.KeyToggleState an= d > KeyData.KeyState.KeyShiftState > + are 0, then any incomplete keystro= ke will trigger a > notification of > + the KeyNotificationFunction. > @param KeyNotificationFunction Points to the function to be calle= d > when the key > - sequence is typed specified by Key= Data. > + sequence is typed specified by Key= Data.This notification > function > + should be called at <=3DTPL_CALLBA= CK. > @param NotifyHandle Points to the unique handle assign= ed to the > registered notification. >=20 > @retval EFI_SUCCESS The notification function was regi= stered > successfully. > @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for > necesssary data structures. > @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or > KeyNotificationFunction is NULL. > diff --git > a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > index 82aa5a6..656d759 100644 > --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > @@ -1,9 +1,9 @@ > /** @file > PS/2 keyboard driver header file >=20 > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be found= at > http://opensource.org/licenses/bsd-license.php >=20 > @@ -492,13 +492,17 @@ KeyboardSetState ( > /** > Register a notification function for a particular keystroke for the = input > device. >=20 > @param This - Protocol instance pointer. > @param KeyData - A pointer to a buffer that is fille= d in with the > keystroke > - information data for the key that was pres= sed. > + information data for the key that w= as pressed.If > KeyData.Key, > + KeyData.KeyState.KeyToggleState and > KeyData.KeyState.KeyShiftState > + are 0, then any incomplete keystrok= e will trigger a > notification of > + the KeyNotificationFunction. > @param KeyNotificationFunction - Points to the function to be called > when the key > - sequence is typed specified by KeyData. > + sequence is typed specified by KeyD= ata.This notification > function > + should be called at <=3DTPL_CALLBAC= K. > @param NotifyHandle - Points to the unique handle assigne= d to the > registered notification. >=20 > @retval EFI_SUCCESS - The notification function was regi= stered > successfully. > @retval EFI_OUT_OF_RESOURCES - Unable to allocate resources for > necesssary data structures. > @retval EFI_INVALID_PARAMETER - KeyData or NotifyHandle is NULL. > diff --git > a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > c > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > c > index 742d009..b04c340 100644 > --- > a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > c > +++ > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > c > @@ -2311,21 +2311,24 @@ Exit: > /** > Register a notification function for a particular keystroke for the in= put > device. >=20 > @param This Protocol instance pointer. > @param KeyData A pointer to a buffer that is filled i= n with the > keystroke > - information data for the key that was = pressed. > + information data for the key that was = pressed.If > KeyData.Key, > + KeyData.KeyState.KeyToggleState and > KeyData.KeyState.KeyShiftState > + are 0, then any incomplete keystroke w= ill trigger a > notification of > + the KeyNotificationFunction. > @param KeyNotificationFunction Points to the function to be called wh= en > the key > - sequence is typed specified by KeyData= . > - @param NotifyHandle Points to the unique handle assigned t= o the > registered notification. > + sequence is typed specified by KeyData= .This notification > function > + should be called at <=3DTPL_CALLBACK. > + @param NotifyHandle Points to the unique handle assigned t= o the > registered notification. >=20 > - > @retval EFI_SUCCESS The notification function was register= ed > successfully. > @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for > necesssary data structures. > @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. > - > -**/ > + > +**/ > EFI_STATUS > EFIAPI > BiosKeyboardRegisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > IN EFI_KEY_DATA *KeyData, > diff --git > a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > h > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > h > index f38411a..c64a131 100644 > --- > a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > h > +++ > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard. > h > @@ -1,8 +1,8 @@ > /** @file >=20 > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
>=20 > This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be foun= d at > @@ -633,21 +633,25 @@ BiosKeyboardSetState ( > /** > Register a notification function for a particular keystroke for the in= put > device. >=20 > @param This Protocol instance pointer. > @param KeyData A pointer to a buffer that is filled i= n with the > keystroke > - information data for the key that was = pressed. > + information data for the key that was = pressed.If > KeyData.Key, > + KeyData.KeyState.KeyToggleState and > KeyData.KeyState.KeyShiftState > + are 0, then any incomplete keystroke w= ill trigger a > notification of > + the KeyNotificationFunction. > @param KeyNotificationFunction Points to the function to be called wh= en > the key > - sequence is typed specified by KeyData= . > - @param NotifyHandle Points to the unique handle assigned t= o the > registered notification. > + sequence is typed specified by KeyData= .This notification > function > + should be called at <=3DTPL_CALLBACK. > + @param NotifyHandle Points to the unique handle assigned t= o the > registered notification. >=20 >=20 > @retval EFI_SUCCESS The notification function was register= ed > successfully. > @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for > necesssary data structures. > @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. > - > -**/ > + > +**/ > EFI_STATUS > EFIAPI > BiosKeyboardRegisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > IN EFI_KEY_DATA *KeyData, > -- > 1.9.5.msysgit.1