public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg/BluetoothConfig: Update comments for GetData/GetRemoteData
Date: Mon, 19 Jun 2017 05:32:39 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B99BFC5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20170619052830.5984-1-hao.a.wu@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, June 19, 2017 1:29 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] MdePkg/BluetoothConfig: Update comments for
> GetData/GetRemoteData
> 
> Updates the GetData and GetRemoteData services description comments
> according to latest UEFI spec.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  MdePkg/Include/Protocol/BluetoothConfig.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/BluetoothConfig.h
> b/MdePkg/Include/Protocol/BluetoothConfig.h
> index 4240ef0a14..1460ee9eb6 100644
> --- a/MdePkg/Include/Protocol/BluetoothConfig.h
> +++ b/MdePkg/Include/Protocol/BluetoothConfig.h
> @@ -1,5 +1,5 @@
>  /** @file
> -  EFI Bluetooth Configuration Protocol as defined in UEFI 2.5.
> +  EFI Bluetooth Configuration Protocol as defined in UEFI 2.7.
>    This protocol abstracts user interface configuration for Bluetooth device.
> 
>    Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR> @@ -
> 12,7 +12,7 @@
>    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> 
>    @par Revision Reference:
> -  This Protocol is introduced in UEFI Specification 2.5
> +  This Protocol is introduced in UEFI Specification 2.7
> 
>  **/
> 
> @@ -273,11 +273,11 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The Bluetooth configuration data is returned
> successfully.
>    @retval EFI_INVALID_PARAMETER One or more of the following conditions
> is TRUE:
>                                  - DataSize is NULL.
> -                                - *DataSize is 0.
> -                                - Data is NULL.
> +                                - *DataSize is not 0 and Data is NULL.
>    @retval EFI_UNSUPPORTED       The DataType is unsupported.
>    @retval EFI_NOT_FOUND         The DataType is not found.
>    @retval EFI_BUFFER_TOO_SMALL  The buffer is too small to hold the buffer.
> +                                *DataSize has been updated with the size needed to
> complete the request.
> 
>  **/
>  typedef
> @@ -327,11 +327,11 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The remote Bluetooth device configuration data
> is returned successfully.
>    @retval EFI_INVALID_PARAMETER One or more of the following conditions
> is TRUE:
>                                  - DataSize is NULL.
> -                                - *DataSize is 0.
> -                                - Data is NULL.
> +                                - *DataSize is not 0 and Data is NULL.
>    @retval EFI_UNSUPPORTED       The DataType is unsupported.
>    @retval EFI_NOT_FOUND         The DataType is not found.
>    @retval EFI_BUFFER_TOO_SMALL  The buffer is too small to hold the buffer.
> +                                *DataSize has been updated with the size needed to
> complete the request.
> 
>  **/
>  typedef
> --
> 2.12.0.windows.1



      reply	other threads:[~2017-06-19  5:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  5:28 [PATCH] MdePkg/BluetoothConfig: Update comments for GetData/GetRemoteData Hao Wu
2017-06-19  5:32 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B99BFC5@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox