public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Tapan Shah <tapandshah@hpe.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg: Update dh command to reflect correct driver field information
Date: Tue, 27 Jun 2017 02:16:53 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9A4F81@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1498513543-5216-1-git-send-email-tapandshah@hpe.com>

Tapan,
Can you change commit message to similar as below?

dh command gets driver name and wrongly prints it as 'Child [handle]'.
It should print it as 'Driver Name [handle]'.

Thanks/Ray

> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Tuesday, June 27, 2017 5:46 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Tapan Shah <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Update dh command to reflect correct driver field
> information
> 
> dh command gets driver name and prints it as 'Child [handle]' instead of
> printing it as 'Driver Name [handle]'.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
>  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c                     | 3 ++-
>  .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni       | 4
> ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 0bcee92..170a868 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -3,6 +3,7 @@
> 
>    (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
>    Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at @@ -664,7 +665,7 @@ DisplayDriverModelHandle (
>      -1,
>      -1,
>      NULL,
> -    STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B),
> +    STRING_TOKEN (STR_DH_OUTPUT_DRIVER7),
>      gShellDriver1HiiHandle,
>      ConvertHandleToHandleIndex(Handle),
>      DriverName!=NULL?DriverName:L"<Unknown>"
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index 52156d5..7a3e61e 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comma
> +++ ndsLib.uni
> @@ -1,6 +1,6 @@
>  // /**
>  //
> -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> +// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development
> +LP<BR>
>  // (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR>
> // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>  //
> This program and the accompanying materials @@ -120,7 +120,7 @@
>  #string STR_DH_OUTPUT_DRIVER5B    #language en-US "
> Parent[%H%02x%N]       : %B%s%N\r\n"
>  #string STR_DH_OUTPUT_DRIVER6     #language en-US "   Child
> Controllers  : %B%s%N\r\n"
>  #string STR_DH_OUTPUT_DRIVER6B    #language en-US "
> Child[%H%02x%N]        : %B%s%N\r\n"
> -#string STR_DH_OUTPUT_DRIVER7     #language en-US "   Driver
> Name        : %B%s%N\r\n"
> +#string STR_DH_OUTPUT_DRIVER7     #language en-US "   Driver Name
> [%H%02x%N]  : %B%s%N\r\n"
>  #string STR_DH_OUTPUT_DRIVER7B    #language en-US "   Driver Image
> Name  : %B%s%N\r\n"
>  #string STR_DH_OUTPUT_DRIVER8     #language en-US "   Driver
> Version     : %B%08x%N\r\n"
>                                                    "   Driver Type        : %B%s%N\r\n"
> --
> 1.9.5.msysgit.0



  reply	other threads:[~2017-06-27  2:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 21:45 [PATCH] ShellPkg: Update dh command to reflect correct driver field information Tapan Shah
2017-06-27  2:16 ` Ni, Ruiyu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-27 18:17 Tapan Shah
2017-06-28  0:55 ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B9A4F81@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox