From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E07A2095D206 for ; Mon, 26 Jun 2017 19:15:28 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 26 Jun 2017 19:16:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,398,1493708400"; d="scan'208";a="278944162" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 26 Jun 2017 19:16:58 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 26 Jun 2017 19:16:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Tue, 27 Jun 2017 10:16:54 +0800 From: "Ni, Ruiyu" To: Tapan Shah , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg: Update dh command to reflect correct driver field information Thread-Index: AQHS7sWWL0I8ncQbekSaO7cSFCNcs6I3+P+A Date: Tue, 27 Jun 2017 02:16:53 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9A4F81@SHSMSX104.ccr.corp.intel.com> References: <1498513543-5216-1-git-send-email-tapandshah@hpe.com> In-Reply-To: <1498513543-5216-1-git-send-email-tapandshah@hpe.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Update dh command to reflect correct driver field information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 02:15:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Tapan, Can you change commit message to similar as below? dh command gets driver name and wrongly prints it as 'Child [handle]'. It should print it as 'Driver Name [handle]'. Thanks/Ray > -----Original Message----- > From: Tapan Shah [mailto:tapandshah@hpe.com] > Sent: Tuesday, June 27, 2017 5:46 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu ; > Tapan Shah > Subject: [PATCH] ShellPkg: Update dh command to reflect correct driver fi= eld > information >=20 > dh command gets driver name and prints it as 'Child [handle]' instead of > printing it as 'Driver Name [handle]'. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah > --- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | = 3 ++- > .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni | = 4 > ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > index 0bcee92..170a868 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > @@ -3,6 +3,7 @@ >=20 > (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at @@ -664,7 +665,7 @@ DisplayDriverModelHandle ( > -1, > -1, > NULL, > - STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B), > + STRING_TOKEN (STR_DH_OUTPUT_DRIVER7), > gShellDriver1HiiHandle, > ConvertHandleToHandleIndex(Handle), > DriverName!=3DNULL?DriverName:L"" > diff --git > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > sLib.uni > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman > dsLib.uni > index 52156d5..7a3e61e 100644 > --- > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > sLib.uni > +++ > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comma > +++ ndsLib.uni > @@ -1,6 +1,6 @@ > // /** > // > -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> +// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development > +LP
> // (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.
> // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
= // > This program and the accompanying materials @@ -120,7 +120,7 @@ > #string STR_DH_OUTPUT_DRIVER5B #language en-US " > Parent[%H%02x%N] : %B%s%N\r\n" > #string STR_DH_OUTPUT_DRIVER6 #language en-US " Child > Controllers : %B%s%N\r\n" > #string STR_DH_OUTPUT_DRIVER6B #language en-US " > Child[%H%02x%N] : %B%s%N\r\n" > -#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver > Name : %B%s%N\r\n" > +#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name > [%H%02x%N] : %B%s%N\r\n" > #string STR_DH_OUTPUT_DRIVER7B #language en-US " Driver Image > Name : %B%s%N\r\n" > #string STR_DH_OUTPUT_DRIVER8 #language en-US " Driver > Version : %B%08x%N\r\n" > " Driver Type = : %B%s%N\r\n" > -- > 1.9.5.msysgit.0