* [PATCH] ShellPkg: Update dh command to reflect correct driver field information
@ 2017-06-27 18:17 Tapan Shah
2017-06-28 0:55 ` Ni, Ruiyu
0 siblings, 1 reply; 4+ messages in thread
From: Tapan Shah @ 2017-06-27 18:17 UTC (permalink / raw)
To: edk2-devel; +Cc: jaben.carsey, ruiyu.ni, Tapan Shah
dh command gets driver name and wrongly prints it as 'Child [handle]'.
It should print it as 'Driver Name [handle]'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 3 ++-
.../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
index 0bcee92..170a868 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
@@ -3,6 +3,7 @@
(C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -664,7 +665,7 @@ DisplayDriverModelHandle (
-1,
-1,
NULL,
- STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B),
+ STRING_TOKEN (STR_DH_OUTPUT_DRIVER7),
gShellDriver1HiiHandle,
ConvertHandleToHandleIndex(Handle),
DriverName!=NULL?DriverName:L"<Unknown>"
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
index 52156d5..7a3e61e 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
@@ -1,6 +1,6 @@
// /**
//
-// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
+// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR>
// (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR>
// Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
// This program and the accompanying materials
@@ -120,7 +120,7 @@
#string STR_DH_OUTPUT_DRIVER5B #language en-US " Parent[%H%02x%N] : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER6 #language en-US " Child Controllers : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER6B #language en-US " Child[%H%02x%N] : %B%s%N\r\n"
-#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name : %B%s%N\r\n"
+#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name [%H%02x%N] : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER7B #language en-US " Driver Image Name : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER8 #language en-US " Driver Version : %B%08x%N\r\n"
" Driver Type : %B%s%N\r\n"
--
2.6.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ShellPkg: Update dh command to reflect correct driver field information
2017-06-27 18:17 [PATCH] ShellPkg: Update dh command to reflect correct driver field information Tapan Shah
@ 2017-06-28 0:55 ` Ni, Ruiyu
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ruiyu @ 2017-06-28 0:55 UTC (permalink / raw)
To: Tapan Shah, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tapan Shah
> Sent: Wednesday, June 28, 2017 2:17 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH] ShellPkg: Update dh command to reflect correct
> driver field information
>
> dh command gets driver name and wrongly prints it as 'Child [handle]'.
> It should print it as 'Driver Name [handle]'.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 3 ++-
> .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni | 4
> ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 0bcee92..170a868 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -3,6 +3,7 @@
>
> (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
> Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at @@ -664,7 +665,7 @@ DisplayDriverModelHandle (
> -1,
> -1,
> NULL,
> - STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B),
> + STRING_TOKEN (STR_DH_OUTPUT_DRIVER7),
> gShellDriver1HiiHandle,
> ConvertHandleToHandleIndex(Handle),
> DriverName!=NULL?DriverName:L"<Unknown>"
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index 52156d5..7a3e61e 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comma
> +++ ndsLib.uni
> @@ -1,6 +1,6 @@
> // /**
> //
> -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> +// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development
> +LP<BR>
> // (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR>
> // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR> //
> This program and the accompanying materials @@ -120,7 +120,7 @@
> #string STR_DH_OUTPUT_DRIVER5B #language en-US "
> Parent[%H%02x%N] : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER6 #language en-US " Child
> Controllers : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER6B #language en-US "
> Child[%H%02x%N] : %B%s%N\r\n"
> -#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver
> Name : %B%s%N\r\n"
> +#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name
> [%H%02x%N] : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER7B #language en-US " Driver Image
> Name : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER8 #language en-US " Driver
> Version : %B%08x%N\r\n"
> " Driver Type : %B%s%N\r\n"
> --
> 2.6.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ShellPkg: Update dh command to reflect correct driver field information
@ 2017-06-26 21:45 Tapan Shah
2017-06-27 2:16 ` Ni, Ruiyu
0 siblings, 1 reply; 4+ messages in thread
From: Tapan Shah @ 2017-06-26 21:45 UTC (permalink / raw)
To: edk2-devel; +Cc: jaben.carsey, ruiyu.ni, Tapan Shah
dh command gets driver name and prints it as 'Child [handle]' instead of
printing it as 'Driver Name [handle]'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 3 ++-
.../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
index 0bcee92..170a868 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
@@ -3,6 +3,7 @@
(C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -664,7 +665,7 @@ DisplayDriverModelHandle (
-1,
-1,
NULL,
- STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B),
+ STRING_TOKEN (STR_DH_OUTPUT_DRIVER7),
gShellDriver1HiiHandle,
ConvertHandleToHandleIndex(Handle),
DriverName!=NULL?DriverName:L"<Unknown>"
diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
index 52156d5..7a3e61e 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni
@@ -1,6 +1,6 @@
// /**
//
-// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
+// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR>
// (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR>
// Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
// This program and the accompanying materials
@@ -120,7 +120,7 @@
#string STR_DH_OUTPUT_DRIVER5B #language en-US " Parent[%H%02x%N] : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER6 #language en-US " Child Controllers : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER6B #language en-US " Child[%H%02x%N] : %B%s%N\r\n"
-#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name : %B%s%N\r\n"
+#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name [%H%02x%N] : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER7B #language en-US " Driver Image Name : %B%s%N\r\n"
#string STR_DH_OUTPUT_DRIVER8 #language en-US " Driver Version : %B%08x%N\r\n"
" Driver Type : %B%s%N\r\n"
--
1.9.5.msysgit.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ShellPkg: Update dh command to reflect correct driver field information
2017-06-26 21:45 Tapan Shah
@ 2017-06-27 2:16 ` Ni, Ruiyu
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ruiyu @ 2017-06-27 2:16 UTC (permalink / raw)
To: Tapan Shah, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Tapan,
Can you change commit message to similar as below?
dh command gets driver name and wrongly prints it as 'Child [handle]'.
It should print it as 'Driver Name [handle]'.
Thanks/Ray
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Tuesday, June 27, 2017 5:46 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Tapan Shah <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Update dh command to reflect correct driver field
> information
>
> dh command gets driver name and prints it as 'Child [handle]' instead of
> printing it as 'Driver Name [handle]'.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 3 ++-
> .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni | 4
> ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 0bcee92..170a868 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -3,6 +3,7 @@
>
> (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.<BR>
> Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at @@ -664,7 +665,7 @@ DisplayDriverModelHandle (
> -1,
> -1,
> NULL,
> - STRING_TOKEN (STR_DH_OUTPUT_DRIVER6B),
> + STRING_TOKEN (STR_DH_OUTPUT_DRIVER7),
> gShellDriver1HiiHandle,
> ConvertHandleToHandleIndex(Handle),
> DriverName!=NULL?DriverName:L"<Unknown>"
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index 52156d5..7a3e61e 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comma
> +++ ndsLib.uni
> @@ -1,6 +1,6 @@
> // /**
> //
> -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> +// (C) Copyright 2016-2017 Hewlett Packard Enterprise Development
> +LP<BR>
> // (C) Copyright 2012-2015 Hewlett-Packard Development Company, L.P.<BR>
> // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR> //
> This program and the accompanying materials @@ -120,7 +120,7 @@
> #string STR_DH_OUTPUT_DRIVER5B #language en-US "
> Parent[%H%02x%N] : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER6 #language en-US " Child
> Controllers : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER6B #language en-US "
> Child[%H%02x%N] : %B%s%N\r\n"
> -#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver
> Name : %B%s%N\r\n"
> +#string STR_DH_OUTPUT_DRIVER7 #language en-US " Driver Name
> [%H%02x%N] : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER7B #language en-US " Driver Image
> Name : %B%s%N\r\n"
> #string STR_DH_OUTPUT_DRIVER8 #language en-US " Driver
> Version : %B%08x%N\r\n"
> " Driver Type : %B%s%N\r\n"
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-28 0:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-27 18:17 [PATCH] ShellPkg: Update dh command to reflect correct driver field information Tapan Shah
2017-06-28 0:55 ` Ni, Ruiyu
-- strict thread matches above, loose matches on Subject: below --
2017-06-26 21:45 Tapan Shah
2017-06-27 2:16 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox