From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2CFE721E1DAE3 for ; Wed, 2 Aug 2017 18:40:03 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 02 Aug 2017 18:42:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,314,1498546800"; d="scan'208";a="135373264" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 02 Aug 2017 18:42:13 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 Aug 2017 18:42:13 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 Aug 2017 18:42:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by shsmsx102.ccr.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002; Thu, 3 Aug 2017 09:42:09 +0800 From: "Ni, Ruiyu" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , Andrew Fish Thread-Topic: [edk2] [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined Thread-Index: AQHTC3G925fwCGO1dUWRka56gU59yKJx3GKQ Date: Thu, 3 Aug 2017 01:42:09 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9C9580@SHSMSX104.ccr.corp.intel.com> References: <1501666085-21208-1-git-send-email-yonghong.zhu@intel.com> <1501666085-21208-3-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1501666085-21208-3-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWEwODBjMWMtMzY4My00ODNmLWJkMjMtNzAzZDVjODRhMzEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdDb25hU2xUK2hMUVwvZ0Z5bWJvdmFTQkVsaUl3bXJDZ2ZKZkozNjVjclJZPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 01:40:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am surprised DuetPkg is still being used. Reviewed-by: Ruiyu Ni Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yon= ghong Zhu >Sent: Wednesday, August 2, 2017 5:28 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Wu, Hao A ; Andrew= Fish >Subject: [edk2] [Patch 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left= shift as undefined > >Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=3D635 > >Cc: Ruiyu Ni >Cc: Hao Wu >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Andrew Fish >--- > DuetPkg/EfiLdr/TianoDecompress.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/DuetPkg/EfiLdr/TianoDecompress.c b/DuetPkg/EfiLdr/TianoDecomp= ress.c >index b504e8e..86d82fc 100644 >--- a/DuetPkg/EfiLdr/TianoDecompress.c >+++ b/DuetPkg/EfiLdr/TianoDecompress.c >@@ -91,15 +91,15 @@ Arguments: > > Returns: (VOID) > > --*/ > { >- Sd->mBitBuf =3D (UINT32) (Sd->mBitBuf << NumOfBits); >+ Sd->mBitBuf =3D (UINT32) (((UINT64)Sd->mBitBuf) << NumOfBits); > > while (NumOfBits > Sd->mBitCount) { > >- Sd->mBitBuf |=3D (UINT32) (Sd->mSubBitBuf << (NumOfBits =3D (UINT16) = (NumOfBits - Sd->mBitCount))); >+ Sd->mBitBuf |=3D (UINT32) (((UINT64)Sd->mSubBitBuf) << (NumOfBits =3D= (UINT16) (NumOfBits - Sd->mBitCount))); > > if (Sd->mCompSize > 0) { > // > // Get 1 byte into SubBitBuf > // >-- >2.6.1.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel