public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Fan, Jeff" <jeff.fan@intel.com>
Subject: Re: [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro.
Date: Mon, 7 Aug 2017 06:30:27 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9CE2B0@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1501752726-14072-8-git-send-email-eric.dong@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Dong, Eric
> Sent: Thursday, August 3, 2017 5:32 PM
> To: edk2-devel@lists.01.org
> Cc: Fan, Jeff <jeff.fan@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro.
> 
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Include/Library/MtrrLib.h | 27 ---------------------------
>  1 file changed, 27 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h
> b/UefiCpuPkg/Include/Library/MtrrLib.h
> index a63da4d..6120526 100644
> --- a/UefiCpuPkg/Include/Library/MtrrLib.h
> +++ b/UefiCpuPkg/Include/Library/MtrrLib.h
> @@ -31,33 +31,6 @@
>  #define  RESERVED_FIRMWARE_VARIABLE_MTRR_NUMBER  2
> 
>  #define  MTRR_NUMBER_OF_FIXED_MTRR      11
> -//
> -// Below macro is deprecated, and should not be used.
> -//
> -#define  FIRMWARE_VARIABLE_MTRR_NUMBER  6
> -#define  MTRR_LIB_IA32_MTRR_CAP                      0x0FE
> -#define  MTRR_LIB_IA32_MTRR_CAP_VCNT_MASK            0x0FF
> -#define  MTRR_LIB_IA32_MTRR_FIX64K_00000             0x250
> -#define  MTRR_LIB_IA32_MTRR_FIX16K_80000             0x258
> -#define  MTRR_LIB_IA32_MTRR_FIX16K_A0000             0x259
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_C0000              0x268
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_C8000              0x269
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_D0000              0x26A
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_D8000              0x26B
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_E0000              0x26C
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_E8000              0x26D
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_F0000              0x26E
> -#define  MTRR_LIB_IA32_MTRR_FIX4K_F8000              0x26F
> -#define  MTRR_LIB_IA32_VARIABLE_MTRR_BASE            0x200
> -//
> -// Below macro is deprecated, and should not be used.
> -//
> -#define  MTRR_LIB_IA32_VARIABLE_MTRR_END             0x20F
> -#define  MTRR_LIB_IA32_MTRR_DEF_TYPE                 0x2FF
> -#define  MTRR_LIB_MSR_VALID_MASK                     0xFFFFFFFFFULL
> -#define  MTRR_LIB_CACHE_VALID_ADDRESS                0xFFFFFF000ULL
> -#define  MTRR_LIB_CACHE_MTRR_ENABLED                 0x800
> -#define  MTRR_LIB_CACHE_FIXED_MTRR_ENABLED           0x400
> 
>  //
>  // Structure to describe a fixed MTRR
> --
> 2.7.0.windows.1



  reply	other threads:[~2017-08-07  6:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  9:31 [Patch 0/7] Remove deprecated macro Eric Dong
2017-08-03  9:32 ` [Patch 1/7] QuarkSocPkg MtrrLib: Enhance get mtrr mask logic Eric Dong
2017-08-07  6:28   ` Ni, Ruiyu
2017-08-03  9:32 ` [Patch 2/7] Vlv2TbltDevicePkg: " Eric Dong
2017-08-07  6:29   ` Ni, Ruiyu
2017-08-03  9:32 ` [Patch 3/7] UefiCpuPkg CpuDxe: " Eric Dong
2017-08-07  6:29   ` Ni, Ruiyu
2017-08-03  9:32 ` [Patch 4/7] QuarkSocPkg MtrrLib: Remove reference deprecated macro Eric Dong
2017-08-03 10:21   ` Ni, Ruiyu
2017-08-04  4:52     ` Dong, Eric
2017-08-04  6:53       ` Ni, Ruiyu
2017-08-07  6:31   ` Ni, Ruiyu
2017-08-03  9:32 ` [Patch 5/7] Vlv2TbltDevicePkg: " Eric Dong
2017-08-03  9:32 ` [Patch 6/7] UefiCpuPkg CpuDxe: " Eric Dong
2017-08-07  6:30   ` Ni, Ruiyu
2017-08-03  9:32 ` [Patch 7/7] UefiCpuPkg MtrrLib: Remove deprecated micro Eric Dong
2017-08-07  6:30   ` Ni, Ruiyu [this message]
2017-08-24 11:07   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5B9CE2B0@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox