From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A57521D18231 for ; Mon, 14 Aug 2017 17:58:05 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2017 18:00:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,375,1498546800"; d="scan'208";a="1182740503" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 14 Aug 2017 18:00:29 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 Aug 2017 18:00:29 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 Aug 2017 18:00:29 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.114]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.135]) with mapi id 14.03.0319.002; Tue, 15 Aug 2017 09:00:04 +0800 From: "Ni, Ruiyu" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" Thread-Topic: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles Thread-Index: AQHTFUzXp4ZNBDBgw0uEPB44oZnDNqKEmO0A Date: Tue, 15 Aug 2017 01:00:03 +0000 Deferred-Delivery: Tue, 15 Aug 2017 01:00:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9ECBF8@SHSMSX104.ccr.corp.intel.com> References: <20170814222944.9608-1-michael.d.kinney@intel.com> In-Reply-To: <20170814222944.9608-1-michael.d.kinney@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 00:58:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, August 15, 2017 6:30 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Wu, Hao A ; > Kinney, Michael D > Subject: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all > consoles >=20 > Add STD_ERROR flag to all output consoles that the Nt32 platform supports > so all messages sent to the standard error console device(s) are visible = by > default. >=20 > The Boot Maintenance Manager can be used to manually disable standard > error output to specific console devices. >=20 > UEFI Applications and UEFI Drivers are recommended to be built with > DEBUG() and ASSERT() messages sent to the standard error device using > MdePkg/Library/UefiDebugLibStdErr. Prior to this change, a user would hav= e > to use the Boot Maintenance Manager to configure a standard error console > device to make these messages visible. >=20 > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Kinney > --- > Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c > b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c > index e92f377bd1..e4b400b4a3 100644 > --- a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c > +++ b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c > @@ -2,7 +2,7 @@ > Defined the platform specific device path which will be filled to > ConIn/ConOut variables. >=20 > -Copyright (c) 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e > found at > @@ -137,19 +137,19 @@ NT_ISA_SERIAL_DEVICE_PATH > gNtSerialDevicePath1 =3D { > PLATFORM_CONSOLE_CONNECT_ENTRY gPlatformConsole[] =3D { > { > (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath0, > - (CONSOLE_OUT | CONSOLE_IN) > + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) > }, > { > (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath1, > - (CONSOLE_OUT | CONSOLE_IN) > + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) > }, > { > (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath0, > - (CONSOLE_OUT | CONSOLE_IN) > + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) > }, > { > (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath1, > - (CONSOLE_OUT | CONSOLE_IN) > + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) > }, > { > NULL, > -- > 2.13.1.windows.2