Re: [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug messages.

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Tuesday, August 15, 2017 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Shao, Ming <ming.shao@intel.com>;
> Shao@ml01.01.org
> Subject: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug
> messages.
> 
> Current debug message when enable/disable CPU feature not correct. This
> patch enhances it to make it more accurate.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Shao, Ming <ming.shao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 8
> ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> index 54c9827..474aea3 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> @@ -528,9 +528,9 @@ AnalysisProcessorFeatures (
>            //
>            SupportedMaskCleanBit (CpuFeaturesData->SettingPcds,
> CpuFeatureInOrder->FeatureMask);
>            if (CpuFeatureInOrder->FeatureName != NULL) {
> -            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Name
> = %a.\n", CpuFeatureInOrder->FeatureName));
> +            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature:
> + Name = %a.\n", CpuFeatureInOrder->FeatureName));
>            } else {
> -            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Mask =
> "));
> +            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature:
> + Mask = "));
>              DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask);
>            }
>          }
> @@ -538,9 +538,9 @@ AnalysisProcessorFeatures (
>          Status = CpuFeatureInOrder->InitializeFunc (ProcessorNumber, CpuInfo,
> CpuFeatureInOrder->ConfigData, FALSE);
>          if (EFI_ERROR (Status)) {
>            if (CpuFeatureInOrder->FeatureName != NULL) {
> -            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Name
> = %a.\n", CpuFeatureInOrder->FeatureName));
> +            DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature:
> + Name = %a.\n", CpuFeatureInOrder->FeatureName));
>            } else {
> -            DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Mask =
> "));
> +            DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature:
> + Mask = "));
>              DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask);
>            }
>          }
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel