From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 510C721E2DA60 for ; Wed, 16 Aug 2017 01:10:33 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2017 01:12:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,381,1498546800"; d="scan'208";a="1163120701" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 16 Aug 2017 01:12:58 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 Aug 2017 01:12:55 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 Aug 2017 01:12:55 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.114]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.128]) with mapi id 14.03.0319.002; Wed, 16 Aug 2017 16:12:53 +0800 From: "Ni, Ruiyu" To: "Dong, Eric" , "edk2-devel@lists.01.org" CC: "Shao, Ming" , "Shao@ml01.01.org" Thread-Topic: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug messages. Thread-Index: AQHTFYfLXHDw3sr+okW50dW4Lh4/DqKGo3vA Date: Wed, 16 Aug 2017 08:12:52 +0000 Deferred-Delivery: Wed, 16 Aug 2017 08:12:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5B9EF3EA@SHSMSX104.ccr.corp.intel.com> References: <1502775098-14688-1-git-send-email-eric.dong@intel.com> In-Reply-To: <1502775098-14688-1-git-send-email-eric.dong@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug messages. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 08:10:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Eric Dong > Sent: Tuesday, August 15, 2017 1:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Shao, Ming ; > Shao@ml01.01.org > Subject: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Enhance debug > messages. >=20 > Current debug message when enable/disable CPU feature not correct. This > patch enhances it to make it more accurate. >=20 > Cc: Ruiyu Ni > Cc: Shao, Ming > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 8 > ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index 54c9827..474aea3 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -528,9 +528,9 @@ AnalysisProcessorFeatures ( > // > SupportedMaskCleanBit (CpuFeaturesData->SettingPcds, > CpuFeatureInOrder->FeatureMask); > if (CpuFeatureInOrder->FeatureName !=3D NULL) { > - DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Nam= e > =3D %a.\n", CpuFeatureInOrder->FeatureName)); > + DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature: > + Name =3D %a.\n", CpuFeatureInOrder->FeatureName)); > } else { > - DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Mas= k =3D > ")); > + DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature: > + Mask =3D ")); > DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask); > } > } > @@ -538,9 +538,9 @@ AnalysisProcessorFeatures ( > Status =3D CpuFeatureInOrder->InitializeFunc (ProcessorNumber, C= puInfo, > CpuFeatureInOrder->ConfigData, FALSE); > if (EFI_ERROR (Status)) { > if (CpuFeatureInOrder->FeatureName !=3D NULL) { > - DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Nam= e > =3D %a.\n", CpuFeatureInOrder->FeatureName)); > + DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature: > + Name =3D %a.\n", CpuFeatureInOrder->FeatureName)); > } else { > - DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature Mas= k =3D > ")); > + DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature: > + Mask =3D ")); > DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask); > } > } > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel