Re: [PATCH v2 0/6] read-only UDF file system support

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Paulo,
1. Could you please run the ECC check tool (BaseTools\Source\Python\Ecc\)
  "CRC" might need to be replaced with "Crc".
  I also noticed some TAB key in file content.

2. Your current implementation uses HARD_DRIVE_DEVICE_PATH.
  But with:
     SignatureType = SIGNATURE_TYPE_UDF
     MBRType = MBR_TYPE_PCAT
     Signature = *
  And later UdfDxe driver checks the SignatureType and MBRType.
  I am not sure if it would be better to put the definitions in UEFI Spec,
  since they are referenced by different modules.
  I also noticed you use PARTITION_TYPE_OTHER for PartitionInfo.
  When proposing to UEFI Spec, this also needs to be considered,
  for example, add PARTITION_TYPE_UDF to spec.

3. The driver model part looks good.

Regards,
Ray

>-----Original Message-----
>From: Paulo Alcantara [mailto:pcacjr@zytor.com]
>Sent: Monday, August 21, 2017 2:16 AM
>To: edk2-devel@lists.01.org
>Cc: Paulo Alcantara <pcacjr@zytor.com>; Laszlo Ersek <lersek@redhat.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
>Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Doran, Mark <mark.doran@intel.com>; Ni, Ruiyu
><ruiyu.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>Subject: [PATCH v2 0/6] read-only UDF file system support
>
>Hi,
>
>This series introduces read-only UDF file system support in EDK2. As
>Laszlo (or Red Hat) seemed to be interested in such support, I'm posting
>it again after ~3 years.
>
>The idea is not replacing the default FAT file system, nor breaking any
>existing file system support, but extending EDK2 with a new file system
>that might be useful for some people who are looking for specific file
>system features that current FAT doesn't support.
>
>Originally the driver was written to support UDF file systems as
>specified by OSTA Universal Disk Format Specification 2.60. However,
>some Windows 10 Enterprise ISO (UDF bridge) images that I tested
>supported a revision of 1.02 thus I had to rework the driver a little
>bit to support such revision as well.
>
>v2:
> - Rework to _partially_ support UDF revisions <2.60.
> - Use existing CDROM_VOLUME_DESCRIPTOR structure defined in Eltorito.h
>   instead of creating another one (UDF_VOLUME_DESCRIPTOR).
> - Fixed UdfDxe to correctly follow UEFI driver model.
> - Use HARDDRIVE_DEVICE_PATH instead of a vendor-defined one.
> - Detect UDF file systems only in PartitionDxe, and let UdfDxe driver
>   check for specific UDF device path to decide whether or not install
>   SimpleFs protocol.
> - Place MdePkg changes in a separate patch.
>
>Repo:   https://github.com/pcacjr/edk2.git
>Branch: udf-fs
>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>Cc: Andrew Fish <afish@apple.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Cc: Eric Dong <eric.dong@intel.com>
>Cc: Mark Doran <mark.doran@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: hao.a.wu@intel.com
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
>---
>
>Paulo Alcantara (6):
>  MdePkg: Add UDF volume structure definitions
>  MdeModulePkg/PartitionDxe: Add UDF file system support
>  MdeModulePkg: Initial UDF/ECMA-167 file system support
>  OvmfPkg: Enable UDF file system support
>  ArmVirtPkg: Enable UDF file system support
>  Nt32Pkg: Enable UDF file system support
>
> ArmVirtPkg/ArmVirtQemu.dsc                         |    3 +-
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc               |    3 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc                   |    3 +-
> ArmVirtPkg/ArmVirtXen.dsc                          |    3 +-
> ArmVirtPkg/ArmVirtXen.fdf                          |    1 +
> .../Universal/Disk/PartitionDxe/Partition.c        |    9 +-
> .../Universal/Disk/PartitionDxe/Partition.h        |   32 +-
> .../Universal/Disk/PartitionDxe/PartitionDxe.inf   |    3 +-
> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c     |  307 +++
> MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c |  185 ++
> MdeModulePkg/Universal/Disk/UdfDxe/File.c          |  901 ++++++++
> MdeModulePkg/Universal/Disk/UdfDxe/FileName.c      |  195 ++
> .../Universal/Disk/UdfDxe/FileSystemOperations.c   | 2375 ++++++++++++++++++++
> MdeModulePkg/Universal/Disk/UdfDxe/Udf.c           |  415 ++++
> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h           | 1246 ++++++++++
> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf      |   66 +
> MdePkg/Include/IndustryStandard/Udf.h              |   60 +
> Nt32Pkg/Nt32Pkg.dsc                                |    1 +
> Nt32Pkg/Nt32Pkg.fdf                                |    1 +
> OvmfPkg/OvmfPkgIa32.dsc                            |    1 +
> OvmfPkg/OvmfPkgIa32.fdf                            |    1 +
> OvmfPkg/OvmfPkgIa32X64.dsc                         |    1 +
> OvmfPkg/OvmfPkgIa32X64.fdf                         |    1 +
> OvmfPkg/OvmfPkgX64.dsc                             |    1 +
> OvmfPkg/OvmfPkgX64.fdf                             |    1 +
> 25 files changed, 5804 insertions(+), 11 deletions(-)
> create mode 100644 MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/File.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/FileName.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.h
> create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
> create mode 100644 MdePkg/Include/IndustryStandard/Udf.h
>
>--
>2.11.0