From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F380A21EB5277 for ; Wed, 30 Aug 2017 23:05:42 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2017 23:08:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,451,1498546800"; d="scan'208";a="1212844658" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 30 Aug 2017 23:08:25 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 Aug 2017 23:08:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 Aug 2017 23:08:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 31 Aug 2017 14:08:23 +0800 From: "Ni, Ruiyu" To: "Dong, Eric" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [Patch] UefiCpuPkg/Mplib.c: Perform complete initialization when enable AP. Thread-Index: AQHTITbDFJxNnGJLEUyFXRV8VWw+oqKd/IYg Date: Thu, 31 Aug 2017 06:08:21 +0000 Deferred-Delivery: Thu, 31 Aug 2017 06:08:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA1C11D@SHSMSX104.ccr.corp.intel.com> References: <1504059706-15492-1-git-send-email-eric.dong@intel.com> In-Reply-To: <1504059706-15492-1-git-send-email-eric.dong@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg/Mplib.c: Perform complete initialization when enable AP. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 06:05:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Dong, Eric > Sent: Wednesday, August 30, 2017 10:22 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > > Subject: [Patch] UefiCpuPkg/Mplib.c: Perform complete initialization when > enable AP. >=20 > PI has description said If an AP is enabled, then the implementation must > guarantee that a complete initialization sequence is performed on the AP,= so > the AP is in a state that is compatible with an MP operating system. > Current implementation just set the AP to idle state when enable this AP > which is not follow spec. This patch fix it. >=20 > Cc: Michael Kinney > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 8394572..924b909 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -1814,7 +1814,7 @@ EnableDisableApWorker ( > if (!EnableAP) { > SetApState (&CpuMpData->CpuData[ProcessorNumber], > CpuStateDisabled); > } else { > - SetApState (&CpuMpData->CpuData[ProcessorNumber], CpuStateIdle); > + ResetProcessorToIdleState (ProcessorNumber); > } >=20 > if (HealthFlag !=3D NULL) { > -- > 2.7.0.windows.1