From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0E64C20958BD8 for ; Thu, 7 Sep 2017 23:23:06 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2017 23:25:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,360,1500966000"; d="scan'208";a="146889181" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 07 Sep 2017 23:25:57 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Sep 2017 23:25:56 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Sep 2017 23:25:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Fri, 8 Sep 2017 14:25:54 +0800 From: "Ni, Ruiyu" To: Paulo Alcantara , "edk2-devel@lists.01.org" CC: Laszlo Ersek , "Justen, Jordan L" , Andrew Fish , "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" , "Dong, Eric" , "Doran, Mark" , "Wu, Hao A" Thread-Topic: [PATCH v5 0/6] read-only UDF file system support Thread-Index: AQHTKC8D+3hMALuQjUOLMeYCOfCQyKKppByAgADh5AA= Date: Fri, 8 Sep 2017 06:25:53 +0000 Deferred-Delivery: Fri, 8 Sep 2017 06:25:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA282B7@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v5 0/6] read-only UDF file system support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 06:23:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Paulo Alcantara [mailto:pcacjr@zytor.com] > Sent: Friday, September 8, 2017 8:56 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Justen, Jordan L > ; Andrew Fish ; Kinney, > Michael D ; Gao, Liming > ; Zeng, Star ; Dong, Eric > ; Doran, Mark ; Ni, Ruiyu > ; Wu, Hao A > Subject: Re: [PATCH v5 0/6] read-only UDF file system support >=20 > Ray, >=20 > On 07/09/2017 20:13, Paulo Alcantara wrote: > > v5: > > - Fixed OVMF IA32 build. > > - Fixed a typo in UdfDriveBindingStop() ("This" -> "SimpleFs") which > > broke retrieval of private fs data from SimpleFs protocol -- > > identified by 'reconnect -r' command in UEFI shell. >=20 > Follow the diff between v4 and v5 for Mde*Pkg changes (forgot to include = it > when resending): >=20 > diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c > b/MdeModulePkg/Universal/Disk/UdfDxe/File.c > index 8ad14fe594..2dbcff0be4 100644 > --- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c > +++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c > @@ -372,7 +372,7 @@ UdfRead ( > PrivFileData->FileSize, > &PrivFileData->FilePosition, > Buffer, > - BufferSize > + (UINT64 *)(UINTN)BufferSize^M > ); > } else if (IS_FID_DIRECTORY_FILE (Parent->FileIdentifierDesc)) { > if (ReadDirInfo->FidOffset =3D=3D 0 && PrivFileData->FilePosition >= 0) { diff -- > git a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c > b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c > index 9f10c78ca9..49dc7077b7 100644 > --- a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c > +++ b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c > @@ -264,7 +264,7 @@ UdfDriverBindingStop ( > EFI_OPEN_PROTOCOL_GET_PROTOCOL > ); > if (!EFI_ERROR (Status)) { > - PrivFsData =3D PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS (This); > + PrivFsData =3D PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS > (SimpleFs);^M >=20 > // > // Uninstall child handle >=20 >=20 > Thanks, > Paulo