* [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
@ 2017-09-22 6:36 Liming Gao
2017-09-22 7:16 ` Ni, Ruiyu
2017-09-22 14:07 ` Carsey, Jaben
0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2017-09-22 6:36 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni
This fix can resolve CLANG38 build failure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
index 062ab5d..c2b60fe 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
@@ -522,7 +522,7 @@ CascadeProcessVariables (
Status = EFI_OUT_OF_RESOURCES;
}
} else {
- Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, &GuidName);
+ Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST CHAR16 **) &GuidName);
if (EFI_ERROR (Status)) {
ShellPrintHiiEx (
-1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), gShellDebug1HiiHandle,
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
2017-09-22 6:36 [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore Liming Gao
@ 2017-09-22 7:16 ` Ni, Ruiyu
2017-09-22 14:07 ` Carsey, Jaben
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ruiyu @ 2017-09-22 7:16 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Friday, September 22, 2017 2:36 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match
> function interface in DmpStore
>
> This fix can resolve CLANG38 build failure.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 062ab5d..c2b60fe 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -522,7 +522,7 @@ CascadeProcessVariables (
> Status = EFI_OUT_OF_RESOURCES;
> }
> } else {
> - Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid,
> &GuidName);
> + Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST
> CHAR16 **) &GuidName);
> if (EFI_ERROR (Status)) {
> ShellPrintHiiEx (
> -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE),
> gShellDebug1HiiHandle,
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore
2017-09-22 6:36 [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore Liming Gao
2017-09-22 7:16 ` Ni, Ruiyu
@ 2017-09-22 14:07 ` Carsey, Jaben
1 sibling, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2017-09-22 14:07 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Liming, I agree this works, but I think Laszlo's change to make the GuidName a CONST CHAR makes more sense.
Jaben
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, September 21, 2017 11:36 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match
> function interface in DmpStore
> Importance: High
>
> This fix can resolve CLANG38 build failure.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 062ab5d..c2b60fe 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -522,7 +522,7 @@ CascadeProcessVariables (
> Status = EFI_OUT_OF_RESOURCES;
> }
> } else {
> - Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid,
> &GuidName);
> + Status = gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONST
> CHAR16 **) &GuidName);
> if (EFI_ERROR (Status)) {
> ShellPrintHiiEx (
> -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE),
> gShellDebug1HiiHandle,
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-22 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 6:36 [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore Liming Gao
2017-09-22 7:16 ` Ni, Ruiyu
2017-09-22 14:07 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox