public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
Date: Mon, 25 Sep 2017 12:44:22 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA68B41@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1506337584-9588-3-git-send-email-liming.gao@intel.com>

Liming,
There is no keyword such as "SOMETIMES_TO_START"?
The DiskIo2 is indeed a TO_START protocol, but optional.

-----Original Message-----
From: Gao, Liming 
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 FatPkg/EnhancedFatDxe/Fat.inf |  2 +-
 FatPkg/FatPei/FatPei.inf      | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf index e7044cd..686b371 100644
--- a/FatPkg/EnhancedFatDxe/Fat.inf
+++ b/FatPkg/EnhancedFatDxe/Fat.inf
@@ -81,7 +81,7 @@
 
 [Protocols]
   gEfiDiskIoProtocolGuid                ## TO_START
-  gEfiDiskIo2ProtocolGuid               ## TO_START
+  gEfiDiskIo2ProtocolGuid               ## SOMETIMES_CONSUMES
   gEfiBlockIoProtocolGuid               ## TO_START
   gEfiSimpleFileSystemProtocolGuid      ## BY_START
   gEfiUnicodeCollationProtocolGuid      ## TO_START
diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f72d..c963429 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -61,9 +61,13 @@
 
 
 [Ppis]
-  gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIoPpiGuid
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIo2PpiGuid
+  gEfiPeiDeviceRecoveryModulePpiGuid          ## PRODUCES
 
 
 [FeaturePcd]
--
2.8.0.windows.1



  reply	other threads:[~2017-09-25 12:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
2017-09-25 11:06 ` [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Liming Gao
2017-09-25 12:48   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Liming Gao
2017-09-25 12:44   ` Ni, Ruiyu [this message]
2017-09-26  3:27     ` Gao, Liming
2017-09-25 11:06 ` [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Liming Gao
2017-09-25 12:46   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Liming Gao
2017-09-25 12:08   ` Dong, Eric
2017-09-25 11:06 ` [Patch 05/11] ShellPkg: Update Guid usage in ShellLib " Liming Gao
2017-09-25 12:47   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
2017-09-26  0:41   ` Fu, Siyuan
2017-10-10  7:24   ` Wu, Jiaxin
2017-09-25 11:06 ` [Patch 07/11] SignedCapsulePkg: Update Guid " Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 08/11] SecurityPkg: " Liming Gao
2017-10-10  8:39   ` Zhang, Chao B
2017-09-25 11:06 ` [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage " Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid " Liming Gao
2017-09-25 11:18   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BA68B41@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox